search

anza-xyz / wallet-adapter

Modular TypeScript wallet adapters and components for Solana applications.
https://anza-xyz.github.io/wallet-adapter/
Apache License 2.0
1.61k stars 962 forks source link

add versioned transaction support for keystone #1002

Closed soralit closed 3 months ago

soralit commented 4 months ago

Hi team, I'm from Keystone team and our latest product Keystone 3 Pro has already supported Versioned transaction so I made this change to support it in wallet-adapter

CHANGES:

  1. update @keystonehq/sol-keyring 's signTransaction method to accept a txHex as Uint8Array but not Transaction any longer to extend the flexibility.
  2. update the signTransaction interface in keystone wallet instance to get the txHex as needed above.
  3. update the supportedTranscations in keystone wallet instance to mark it as already supported Versioned Transaction.
jordaaash commented 4 months ago

We're also going to need a changeset added for this to release it. I mention this because the fork's branch doesn't look like it'll allow me to add the changeset to this PR.

soralit commented 4 months ago

Thanks for reviewing, will have a change later. About the changeset can you tell me how to add it? Or maybe you could raise a PR in our repo to this branch to add it.

jordaaash commented 3 months ago

I've merged this into a feature branch since it needs a changeset before it can be merged to master. I'll handle that.