search

anza-xyz / wallet-adapter

Modular TypeScript wallet adapters and components for Solana applications.
https://anza-xyz.github.io/wallet-adapter/
Apache License 2.0
1.59k stars 960 forks source link

Ledger signMessage support #171

Open hudymvol opened 2 years ago

hudymvol commented 2 years ago

Hi, are there any plans to add signMessage support for Ledger?

As far as I can see, it is not available at the current moment.

neverything commented 2 years ago

@hudymvol the issue seems to go a little deeper: https://github.com/phantom-labs/sandbox/issues/14

influento commented 2 years ago

@neverything I'm not an expert in this but, as I can see during the transaction we also getting some signature. Won't it be possible just to implement function signMessage and return that signature? I believe signature which is created during the transaction has the same creation logic as signature which should be created during message signing.

neverything commented 2 years ago

@Crispried iirc this is a different type of signature that gets created differently. The signMessage can be done just between the wallet and the website and doesn't need a connection to the blockchain itself to be generated.

influento commented 2 years ago

@neverything so, the way how wallets create signatures for transactions is different from the way how they create signatures for message? I was sure it's the same. I believe it means they use different cryptography algorithms for that. Could you explain how it works? Or maybe share some links where I could read about that?

My point was that if we can get signature from Ledger but, by calling some "non-standard" API from Ledger side then let it be and we could handle that on wallet adapter level. The main thing is to get the signature. But, obviously if the way how transaction are signed is completely different from the way how message are signed it doesn't make sense.

devourer66 commented 2 years ago

Has anyone reached to Solana ledger app devs?

neverything commented 2 years ago

@devourer66 yes, I think the Phantom folks have already raised this: https://github.com/phantom-labs/sandbox/issues/14

jordaaash commented 2 years ago

Just back from vacation! This is currently blocked by https://github.com/solana-labs/solana/issues/21366. Once it's supported natively in the Ledger app, we can find out how support it in the adapter.

neverything commented 2 years ago

Seems like there is some good news out and this will hopefully be delivered in Q1 2022, according to https://github.com/solana-labs/solana/issues/21366#issuecomment-994886128

Sunnyjson commented 2 years ago

hey guys, is there any progress in ledger support

jordaaash commented 2 years ago

@Sunnyjson this isn't the place to track Ledger features. Please subscribe to the above linked tracking issue.

raghibislam commented 2 years ago

Hey , guys any update on signMessage function ?

LenChou95 commented 2 years ago

Hey , guys any update on signMessage function?

heymike777 commented 2 years ago

Hey, any update on signMessage function?

kizzx2 commented 2 years ago

Since it isn't like this is coming any time soon, I've created an app that let's user just send a amount of SOL to "sign a message": https://github.com/kizzx2/solana-sign-with-payment

ChewingGlass commented 2 years ago

I'll add my message to the graveyard here, any update?

neverything commented 2 years ago

See https://github.com/phantom-labs/sandbox/issues/14#issuecomment-1178510137