Fullscreen doesn't open wallets

anza-xyz / wallet-adapter

Modular TypeScript wallet adapters and components for Solana applications.

https://anza-xyz.github.io/wallet-adapter/

Apache License 2.0

1.57k stars 948 forks source link

Fullscreen doesn't open wallets #784

Open CalvinMaighan opened 1 year ago

CalvinMaighan commented 1 year ago

When you are in fullscreen on a mac (I always code in fullscreen splitting between my editor and chrome) and click on a wallet (I've tested with Phantom) it does not open until you exit fullscreen and it shows nothing to the user suggesting to close fullscreen. Ideally there would be a way to not have to close fullscreen every time you want to sign something.

jordaaash commented 1 year ago

This sounds like an OS / browser / extension issue. If the behavior is consistent across several browser extension wallets, it's probably not something they can change. This certainly isn't a limitation of Wallet Adapter, so I'm closing this issue.

jordaaash commented 1 year ago

Oh, I see. You're saying that the app should warn the user that they are in fullscreen, or try to exit fullscreen, so that the extension will open? Sounds tricky to get right, but I'll leave this open to consider.

mcintyre94 commented 1 year ago

I can't repro this on macOS/Chrome fullscreen. For Glow, Backpack and Phantom on the example app I get switched to the wallet UI:

https://github.com/solana-labs/wallet-adapter/assets/1711350/68172d54-bd14-4a91-911e-2f001db40078

Not an ideal UX but I'm not seeing this bug where it doesn't open the wallet

Which browser and app are you seeing this on?