search

anza-xyz / wallet-adapter

Modular TypeScript wallet adapters and components for Solana applications.
https://anza-xyz.github.io/wallet-adapter/
Apache License 2.0
1.55k stars 944 forks source link

feat: revamp `particleAdapter` #854

Closed TABASCOatw closed 9 months ago

TABASCOatw commented 10 months ago

As an alternative to the previous PR, this purely updates the adapter to function with the new version of Particle's solana-wallet SDK, restoring standard functionality to the adapter (which it currently lacks due to the outdated structure and solana-wallet version).

This removes the previous social login display customization changes & abides by the 1 SDK rule.

socket-security[bot] commented 10 months ago

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

TABASCOatw commented 9 months ago

GM @jordaaash! Anything else you'd like to be done here? Happy to make any other changes; let me know 👍

TABASCOatw commented 9 months ago

Just checking in here again @jordaaash

TABASCOatw commented 9 months ago

Hey @jordaaash! Happy New Year! Just wanted to bump this and see if there was anything else that I could do here to push it through?

jordaaash commented 9 months ago

Catching up on this now. Sorry for the delay!

TABASCOatw commented 9 months ago

Catching up on this now. Sorry for the delay!

No problem at all, thank you!

TABASCOatw commented 9 months ago

Okay, a few small changes left. I enabled the build to run, but it looks broken. Can you commit the pnpm lockfile changes? I also ran the build locally, and it fails with this error:

@solana/wallet-adapter-particle:build: ../../../node_modules/.pnpm/@particle-network+solana-wallet@1.2.1_@particle-network+auth@0.5.6_@solana+web3.js@1.78.0_bs58@4.0.1/node_modules/@particle-network/solana-wallet/lib/types/solana-wallet.d.ts(1,16): error TS2305: Module '"@particle-network/auth"' has no exported member 'LoginOptions'.

Just pushed changes addressing those additional comments and fixed the build issue - I went ahead and added my pnpm lockfile to the commit to. The build is working locally for me, could you check again on your side?

Additionally, important to note that this change adds an additional dev dependency to the adapter package, @metamask/eth-sig-util, I tried a few workarounds but it isn't saved as a peer dep and instead needs to be included here to avoid that build issue you ran into, the other option would be to ignore it but could cause some issues.

jordaaash commented 9 months ago

Followup PR to fix and release this @ https://github.com/solana-labs/wallet-adapter/pull/877

jordaaash commented 9 months ago

Released via https://github.com/solana-labs/wallet-adapter/pull/878