search

anza-xyz / wallet-adapter

Modular TypeScript wallet adapters and components for Solana applications.
https://anza-xyz.github.io/wallet-adapter/
Apache License 2.0
1.55k stars 944 forks source link

Update mobile adapter #882

Open Funkatronics opened 8 months ago

Funkatronics commented 8 months ago

@jordaaash I think I got our libs all fixed up. This branch is currently using @solana-mobile/wallet-adapter-mobile v2.1.0-alpha1 and its building a testing both locally and on CI (I think)

I am going to test this alpha build a bit more then publish a proper 2.1.0 release and update this PR

socket-security[bot] commented 8 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@solana-mobile/wallet-adapter-mobile@2.1.1 Transitive: environment, eval, filesystem, network, shell, unsafe +592 184 MB

🚮 Removed packages: npm/@solana-mobile/wallet-adapter-mobile@2.0.1

View full report↗︎

Funkatronics commented 8 months ago

@jsx bump. Do you have any concerns with merging this?

Funkatronics commented 5 months ago

@jordaaash there are a couple remaining dupes:

/@solana/wallet-standard-wallet-adapter-base@1.1.2(@solana/web3.js@1.78.0)(bs58@4.0.1)
/@solana/wallet-standard-wallet-adapter-base@1.1.2(@solana/web3.js@1.78.0)(bs58@5.0.0)

and

/@solana/wallet-standard-wallet-adapter-react@1.1.2(@solana/wallet-adapter-base@packages+core+base)(@solana/web3.js@1.78.0)(bs58@4.0.1)(react@18.2.0)
/@solana/wallet-standard-wallet-adapter-react@1.1.2(@solana/wallet-adapter-base@packages+core+base)(@solana/web3.js@1.78.0)(bs58@5.0.0)(react@18.2.0)

due to bs58 differences. @solana-mobile/mobile-wallet-adapter-protocol-web3js uses bs58@5.0.0, while @solana/wallet-standard-wallet-adapter-base uses bs58@4.0.1. I have not been able to resolve this without changing the dependency on our end.

Thoughts?