search

anza-xyz / wallet-adapter

Modular TypeScript wallet adapters and components for Solana applications.
https://anza-xyz.github.io/wallet-adapter/
Apache License 2.0
1.46k stars 911 forks source link

Coinbase Wallet Adapter: Add supported transaction versions #906

Closed willnewman-cb closed 4 months ago

willnewman-cb commented 4 months ago

This PR updates the Coinbase Wallet adapter to properly list the supported transaction versions. Versioned transaction support was recently added to Coinbase Wallet.

I also cleaned up the TS a bit on the interface.

Tested locally that the correct tx versions are returned and that signing works as expected.

jordaaash commented 4 months ago

Thanks! Can I get you to consider implementing the Wallet Standard in Coinbase Wallet? It's a pretty quick nonbreaking change that can be made with no dependencies and it will make Coinbase Wallet work on most Solana apps without requiring an adapter at all.

willnewman-cb commented 4 months ago

Yeah, it's on the roadmap! Not sure of timeline but it shouldn't be too long :)

jordaaash commented 4 months ago

Cool! I added a changeset and ran the tests, can you check on the test failure?

willnewman-cb commented 4 months ago

@jordaaash – fixed the type issue, build ran fine locally. Don't think I have permission to run it again here