search

anza-xyz / wallet-adapter

Modular TypeScript wallet adapters and components for Solana applications.
https://anza-xyz.github.io/wallet-adapter/
Apache License 2.0
1.44k stars 906 forks source link

Bumping the minor version for the `walletconnect` package #942

Open jnwng opened 3 months ago

jnwng commented 3 months ago

i missed this when @jnwng/walletconnect-solana@0.3.0 got released

Fatih-Hocur commented 1 month ago

Hi, do you have any updates on the status of this PR? When can we expect it to be merged? Thanks!

deadeagle63 commented 1 month ago

@jnwng do we have an ETA on this potentially going in? :D

usgoose commented 1 month ago

Would be helpful to get this in for some Solana protocols facing issues 🙏 @jnwng

jordaaash commented 3 weeks ago

Build failing:

@solana/wallet-adapter-walletconnect:build: ../../../node_modules/.pnpm/@walletconnect+core@2.13.2_@react-native-async-storage+async-storage@1.19.1_bufferutil@4.0.7_utf-8-validate@5.0.10/node_modules/@walletconnect/core/dist/types/controllers/relayer.d.ts:13:5 - error TS2416: Property 'provider' in type 'Relayer' is not assignable to the same property in base type 'IRelayer'.
@solana/wallet-adapter-walletconnect:build:   Type 'import("/Users/jordan/Github/anza-xyz/wallet-adapter/node_modules/.pnpm/@walletconnect+jsonrpc-types@1.0.3/node_modules/@walletconnect/jsonrpc-types/dist/cjs/provider").IJsonRpcProvider' is not assignable to type 'import("/Users/jordan/Github/anza-xyz/wallet-adapter/node_modules/.pnpm/@walletconnect+jsonrpc-types@1.0.4/node_modules/@walletconnect/jsonrpc-types/dist/types/provider").IJsonRpcProvider'.
@solana/wallet-adapter-walletconnect:build:     Property 'setConnection' is protected but type 'IJsonRpcProvider' is not a class derived from 'IJsonRpcProvider'.
@solana/wallet-adapter-walletconnect:build:
@solana/wallet-adapter-walletconnect:build: 13     provider: IJsonRpcProvider;
@solana/wallet-adapter-walletconnect:build:        ~~~~~~~~
@solana/wallet-adapter-walletconnect:build:
@solana/wallet-adapter-walletconnect:build:
@solana/wallet-adapter-walletconnect:build: Found 2 errors.
@solana/wallet-adapter-walletconnect:build:
@solana/wallet-adapter-walletconnect:build:  ELIFECYCLE  Command failed with exit code 1.
@solana/wallet-adapter-walletconnect:build: ERROR: command finished with error: command (/Users/jordan/Github/anza-xyz/wallet-adapter/packages/wallets/walletconnect) /Users/jordan/Github/anza-xyz/wallet-adapter/node_modules/.bin/pnpm run build exited (1)
@solana/wallet-adapter-walletconnect#build: command (/Users/jordan/Github/anza-xyz/wallet-adapter/packages/wallets/walletconnect) /Users/jordan/Github/anza-xyz/wallet-adapter/node_modules/.bin/pnpm run build exited (1)
glitch-txs commented 1 week ago

Hello, we've fork jnwng's repo and soon release the adapter as a standalone library, we will also soon open a PR to update it here.

I'd appretiate everyone's feedback: https://github.com/WalletConnect/walletconnect-solana

This can be closed for now 👍