search

anza-xyz / wallet-adapter

Modular TypeScript wallet adapters and components for Solana applications.
https://anza-xyz.github.io/wallet-adapter/
Apache License 2.0
1.61k stars 962 forks source link

Add OKX wallet adapter #993

Closed h0lme3 closed 3 months ago

h0lme3 commented 4 months ago

Hi everybody,

We want to let users connect OKX wallet in our dApp and we are using @solana/wallet-adapter-wallets dep which is not listed yet

Can we add okx wallet like okx wallet adapter?

Thanks

glitch-txs commented 4 months ago

Any plans on supporting the Wallet Standard?

puderty commented 4 months ago

Hi everybody,

We want to let users connect OKX wallet in our dApp and we are using @solana/wallet-adapter-wallets dep which is not listed yet

Can we add okx wallet like okx wallet adapter?

Thanks

which dApp and what platform is it? I think okx wallet already supported wallet adapter

h0lme3 commented 4 months ago

which dApp and what platform is it? I think okx wallet already supported wallet adapter

Hmm I believe I am using the latest @solana/wallet-adapter-wallets version (^0.19.32) and it doesnt include okx wallet adapter at the moment, I think.

h0lme3 commented 4 months ago

Any plans on supporting the Wallet Standard?

Not now, just wrote for the feature request for now.

kAsky53 commented 4 months ago

Any plans on supporting the Wallet Standard?

It already supports wallet standard. I think it's still useful for installation though.

glitch-txs commented 4 months ago

Then why do you need the adapter?

kAsky53 commented 4 months ago

Then why do you need the adapter?

If I have not installed OKX wallet, I would still like it to be shown in available wallet list where I can click and install the wallet app.

glitch-txs commented 4 months ago

what's your expected behavior when clicked by a user?

kAsky53 commented 4 months ago

what's your expected behavior when clicked by a user?

It should redirect to https://www.okx.com/web3 so that I can install the wallet app.

image image

glitch-txs commented 4 months ago

you could create a custom adapter and add name, icon and url as config args rather than one for each wallet. I guess it only needs to be filtered by WS and trigger the URL on connect

kAsky53 commented 4 months ago

you could create a custom adapter and add name, icon and url as config args rather than one for each wallet. I guess it only needs to be filtered by WS and trigger the URL on connect

Would you mind sharing code snippet for it?

jordaaash commented 3 months ago

Thanks, but we are not accepting new adapters for wallets that can support the Wallet Standard. Since OKX Wallet already does, this is unnecessary.