anza-xyz / wallet-standard

Solana extensions to the Wallet Standard.
Apache License 2.0
82 stars 42 forks source link

Use latest @solana/wallet-adapter-base, export reusable feature names #11

Closed jordaaash closed 1 year ago

jordaaash commented 1 year ago

https://github.com/solana-labs/wallet-adapter/pull/726 moved some of the types from @solana/wallet-standard-wallet-adapter-base into @solana/wallet-adapter-base. This PR updates @solana/wallet-standard-wallet-adapter-base to use and re-export them.

Additionally, following https://github.com/wallet-standard/wallet-standard/pull/79, apps and wallets needing to feature detect with strings like if ("solana:signTransaction") in wallet.features is verbose and error prone. Exporting and using these feature names as constant strings will help.

Blocked by https://github.com/wallet-standard/wallet-standard/pull/79

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 57ddcbd74e171a7b0dae1712abd03008379b3ef7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | -------------------------------------------- | ----- | | @solana/wallet-standard-wallet-adapter-react | Patch | | @solana/wallet-standard-wallet-adapter-base | Patch | | @solana/wallet-standard-features | Patch | | @solana/wallet-standard-wallet-adapter | Patch | | @solana/wallet-standard | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR