The window.walletName global may be dangerous, and we should remove it from the docs.

[mikemaccana]

Describe the bug https://github.com/solana-labs/wallet-standard/blob/master/WALLET.md states, after registering the wallet implementation:

// Attach the reference to the window, guarding against errors.
try {
    Object.defineProperty(window, 'uniqueNewYork', { value: uniqueNewYork });
}
catch (error) {
    console.error(error);
}

We should probably remove this:

• The global seems to be unnecessary - registering the wallet is enough for the wallet to work. Removing the global would avoid unnecessary complexity, Exupery's law, etc.
• HTML element IDs are globals - yes under window, not just window.document. As wallets are loaded on all web pages, and the element IDs being globals is expected behaviour (it goes all the way to Internet Explorer) there's a non-zero chance a wallet name will conflict with an element ID on an arbitrary web page.

• There's a smaller chance a wallet name may conflict with an existing well-known global. Maybe someone is new to web dev and thinks navigator is a good name for their new wallet (in this case defineProperty() will work, then things will start failing for the rest of the page).

  Happy to submit a PR just thought a discussion would be preferred in case I'm missing something.

[jordaaash]

Thanks Mike.

The Ghost wallet example isn't a suggestion that wallets should implement window globals. That code demonstrates for wallets that already do this (almost all of them, especially ones that approximate Phantom's API) how to do it somewhat more safely, but primarily it demonstrates how to add support for the Wallet Standard (in a nonbreaking way for applications that may rely on the globals they already have).

To drive adoption for the Wallet Standard, we have to meet wallets where they are and make it easy to adopt. On the Wallet Adapter side, we have already stopped accepting PRs for new adapters that can instead use the Wallet Standard.

[mikemaccana]

Got it. I've made a small PR making this explicit in the docs.