search

anza-xyz / wallet-standard

Solana extensions to the Wallet Standard.
Apache License 2.0
79 stars 42 forks source link

remove warning for bs58 5.0.0 #36

Closed beeman closed 2 months ago

beeman commented 10 months ago

When installing @solana/wallet-adapter-react, this message appears when you have the latest version of bs58 installed.

warning "@solana/wallet-adapter-react > @solana/wallet-standard-wallet-adapter-react > @solana/wallet-standard-wallet-adapter-base@1.1.1" has incorrect peer dependency "bs58@^4.0.1".

This patch widens the dependency range.

beeman commented 7 months ago

Friendly ping, would be great if this could be merged! 🙌

jordaaash commented 7 months ago

Looks good! Can you add a patch changeset?

jordaaash commented 7 months ago

Hmm actually, I need to think about this change and see how we're using the dependency. bs58 5 breakingly changes from Buffer to Uint8Array types.

gcangussu commented 4 months ago

This affect us as well, the warning show up every time we install/change dependencies. I can report that we've been using this package with bs58@5.0.0 without any issues for the past months.

beeman commented 4 months ago

This affect us as well, the warning show up every time we install/change dependencies. I can report that we've been using this package with bs58@5.0.0 without any issues for the past months.

Same, zero issues since the moment I created this PR.

I think we're safe here 😄