anza-xyz / wallet-standard

Solana extensions to the Wallet Standard.
Apache License 2.0
79 stars 42 forks source link

Include `signInFeature` in the features for `SolanaWalletAdapterWallet` #46

Open alex-fung opened 3 months ago

alex-fung commented 3 months ago

This PR is sequenced after https://github.com/wallet-standard/wallet-standard/pull/101

SolanaWalletAdapterWallet was missing signInFeature, so anything wrapped it in would be missing the signIn method.

Since the Standard Wallet Adapter will be updating the account upon successful SIWS (here), it's possible that the #account in the StandardWalletAdapter is different from the #account in SolanaWalletAdapterWallet . This then causes issues when there's an equality check of the accounts when the SolanaWalletAdapterWallet sets it to be something custom here. Hence, updating the equality checks to use the deep equality checks from https://github.com/wallet-standard/wallet-standard/pull/101, instead of reference equality checks