Loosen input requirements for byte arrays; they can now implement just the read interface

anza-xyz / wallet-standard

Solana extensions to the Wallet Standard.

Apache License 2.0

79 stars 42 forks source link

Loosen input requirements for byte arrays; they can now implement just the read interface #64

Closed steveluscher closed 2 months ago

steveluscher commented 2 months ago

Though unintuitive, this PR actually makes the input type of Wallet Standard methods less restrictive. They will now take not only Uint8Arrays, but things shaped like Uint8Arrays that behave more read-only like.

The motivation here is to make Wallet Standard more compatible with libraries like @solana/web3.js that deal in ReadonlyUint8Array.

steveluscher commented 2 months ago

#56 : 2 dependent PRs (#52 , #53 )
#51
#64 👈
#63
#49 : 1 other dependent PR (#50 )
#48
#62
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite

steveluscher commented 2 months ago

Merge activity

Jun 7, 11:24 AM PDT: @steveluscher started a stack merge that includes this pull request via Graphite.
Jun 7, 11:36 AM PDT: Graphite rebased this pull request as part of a merge.
Jun 7, 11:37 AM PDT: @steveluscher merged this pull request with Graphite.