anze3db / fedidevs

Discover amazing developers across the fediverse 🌐
https://fedidevs.com
MIT License
22 stars 6 forks source link

Improve grid (use masonry style posts) #21

Closed hyperNURb closed 6 months ago

hyperNURb commented 6 months ago

👋 The current homepage has a gap in posts due to the grid height. Since CSS masonry still has very limited support, I propose to change it to flex.

Issue:

Screenshot 2024-03-21 at 22 17 50

Proposed fix:

https://github.com/anze3db/fedidevs/assets/59742/5b5fd29f-f32e-46c6-a428-d65a34e449bf

anze3db commented 6 months ago

This looks awesome!

I can't merge just yet, because it looks like there is a glitch:

Screenshot 2024-03-21 at 23 27 21

I'll take a look at it tomorrow though, but now I need to go to sleep because I'm supposed to go surfing in 6 hours 🙈

anze3db commented 6 months ago

I can't seem to get the thing to work. No matter what I do issues pop up somewhere:

https://github.com/anze3db/fedidevs/assets/513444/6f8e524a-27be-4da7-b2d4-f43790897c65

Maybe the problem would be easier to solve if we clipped the description field and make sure all account cards have the same height and width? 🤔

anze3db commented 6 months ago

I've tried masonry-layout js lib, and it seems to work decently well:

https://github.com/anze3db/fedidevs/assets/513444/d0a2a4e7-60bf-4289-bcba-2abe4b241835

anze3db commented 6 months ago

Alternative solution using JS (booo): https://github.com/anze3db/fedidevs/pull/25

anze3db commented 6 months ago

Closing in favor of https://github.com/anze3db/fedidevs/pull/25