anzwdev / al-code-outline

AL Code Outline for Visual Studio Code
MIT License
51 stars 13 forks source link

RemoveProceduresSemicolon - does not remove semicolon from triggers #541

Closed ThorstenEngelsGOB closed 2 months ago

ThorstenEngelsGOB commented 6 months ago

The new procedure RemoveProceduresSemicolon removes the redundant semicolon at the end of a function but not at the end of a trigger, such as trigger OnRename(); or trigger OnModify; The search criterion and the fix should be extended to trigger so that the LinterCOP used no longer issues the warning LC00024.

NKarolak commented 6 months ago

I just wanted to report the same. It ignores also to triggers in codeunits, think of OnInstallAppPerCompany in an install codeunit.

pri-kise commented 5 months ago

ControlAddin Triggers are ignored, too.

            usercontrol(Magic; "PTE Magic")
            {
                ApplicationArea = all;

                trigger OnControlIsReady(); //Not needed semicolon
                begin
                    CurrPage.Magic.InitializeControl();
                end;
            }
anzwdev commented 3 months ago

Thank you for reporting your issue. The fix is available in the last release.