search

anzwdev / al-code-outline

AL Code Outline for Visual Studio Code
MIT License
51 stars 14 forks source link

Fields selection is not working anymode #603

Open mihaivalceaCPS opened 3 months ago

mihaivalceaCPS commented 3 months ago

Hi,

I cannot select and add fields to page. After I check a field in fields list the check mark si automatically disabled.

Regards, Mihai

barandeniz commented 3 months ago

I am experiencing same issue also.

pri-kise commented 3 months ago

I found this in the VS Code repository: https://github.com/microsoft/vscode/issues/223363

erikrijn commented 3 months ago

Just to let you know, same issue here for the last couple of weeks. First I wasn't able to select fields like the issue starter. Now, the whole selections screen won't appear anymore.

mihaivalceaCPS commented 3 months ago

The issue still exists and maybe un update is required.

From: Erik van Rijn @.> Sent: Monday, August 12, 2024 3:05 PM To: anzwdev/al-code-outline @.> Cc: mihaivalceaCPS @.>; Author @.> Subject: Re: [anzwdev/al-code-outline] Fields selection is not working anymode (Issue #603)

Just to let you know, same issue here for the last couple of weeks.

— Reply to this email directly, view it on GitHub https://github.com/anzwdev/al-code-outline/issues/603#issuecomment-2283789227 , or unsubscribe https://github.com/notifications/unsubscribe-auth/BKLATA6JB3JISR3NJB3XIKDZRCQHNAVCNFSM6AAAAABMBSPVG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTG44DSMRSG4 . You are receiving this because you authored the thread. https://github.com/notifications/beacon/BKLATA4GAKTZRMXU6ZCJE6DZRCQHNA5CNFSM6AAAAABMBSPVG6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUID7N2W.gif Message ID: @. @.> >

anzwdev commented 3 months ago

It is broken in the latest version of VS Code. I am checking if it is a bug or vs code api change.

anzwdev commented 3 months ago

The issue was caused by changes to the vs code api. One of the properties of pick list items that were ignored in the previous versions needs to be set now. I've released a new version of the extension, problem should be solved now.

alan0z commented 3 months ago

@anzwdev after update to v14.0.956192 (pre-release) still not works. Tested on PageExt and Pages. Still impossble to "check" the checkbox. VSCode: Version: 1.92.1 (system setup) Commit: eaa41d57266683296de7d118f574d0c2652e1fc4 Date: 2024-08-07T20:16:39.455Z Electron: 30.1.2 ElectronBuildId: 9870757 Chromium: 124.0.6367.243 Node.js: 20.14.0 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.19045

dannoe commented 3 months ago

@alan0z Try version 13.70.0 (non prerelease)

pri-kise commented 3 months ago

For me it isn't working with the latest version. I installed the version v13.70.0 of the extension and closed all VS Code windows.

VS Code: Version: 1.92.1 (user setup) Commit: eaa41d57266683296de7d118f574d0c2652e1fc4 Date: 2024-08-07T20:16:39.455Z

sofiaagmp commented 3 months ago

It also still isn't working on my end. Even with the latest version.

alan0z commented 3 months ago

@alan0z Try version 13.70.0 (non prerelease)

The same result :(

dannoe commented 3 months ago

As a temporary workaround you can search for the following file:

C:\Users\<username>\.vscode\extensions\andrzejzwierzchowski.al-code-outline-13.70.0\out\codeactions\addFields\tableFieldsSelector.js

And comment out line 121:

//this._quickPick.items = newItems;

The sorting after selected items isn't working with this, but at least it is usable. This change will be lost if you install a new version.

sofiaagmp commented 3 months ago

As a temporary workaround you can search for the following file:

C:\Users\<username>\.vscode\extensions\andrzejzwierzchowski.al-code-outline-13.70.0\out\codeactions\addFields\tableFieldsSelector.js

And comment out line 121:

//this._quickPick.items = newItems;

The sorting after selected items isn't working with this, but at least it is usable. This change will be lost if you install a new version.

I tried this and still doesn't let me select anything.

dannoe commented 3 months ago

I tried this and still doesn't let me select anything.

Did you reload or restart vscode after changing the file? Is your current active version of the al-code-outline extension 13.70.0?

sofiaagmp commented 3 months ago

I tried this and still doesn't let me select anything.

Did you reload or restart vscode after changing the file? Is your current active version of the al-code-outline extension 13.70.0?

Tried again and it is working. Thank you!

anzwdev commented 3 months ago

I've found what was wrong. The latest version of VS Code triggers quick pick events in a different way. New version is ready, it should work for you now.

pri-kise commented 3 months ago

I updated my VS Code today.

Version: 1.92.2 (user setup) Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9 Date: 2024-08-14T17:29:30.058Z

and now it's working again with version v13.71.0.