search

anzz1 / TacoTip

Better player tooltips - class colors, talents/specialization, GearScore & more - for Classic / TBC / WoTLK
8 stars 18 forks source link

fix: add expac specific toc files to fix out of date issue #21

Open Ahummeling opened 1 year ago

Ahummeling commented 1 year ago

As was explained in #20, it's really annoying the addon is permantently out of date. This PR is aimed to resolve this issue by implementing the specific toc files for the respective versions of classic. Please let me know if anything needs to change before this PR can be merged, happy to receive feedback.

anzz1 commented 1 year ago

Wait a minute, is this how it works nowadays? As my understanding has been that since pretty much the dawn of time, you would have to update the TOC interface version every single time a new build is out. So as explained already in #9 , I wasn't going to be bothered with that.

So setting the interface version once would now make it permanently not "out-of-date"? Are you sure this is how it works, since plenty of people do keep updating the interface version.

I'm also having a hard time understanding how do people keep into running this issue? As people seem to get this nag on "every update". Is there a bug I'm not aware of, that the option gets disabled somehow? While myself I literally checked the "load out-of-date addons" checkbox once and never saw the nag again, even with updates happening in between.

My point of view of the whole issue is that the nag is a ridiculously stupid thing, which you can simply disable with literally a single click. But if the nag is getting re-enabled and the error message keeps happening over and over again, then it's definitely something to look into.

Ahummeling commented 1 year ago

I'm also having a hard time understanding how do people keep into running this issue? As people seem to get this nag on "every update". Is there a bug I'm not aware of, that the option gets disabled somehow?

Yeah so my options were similar to yours at first, but now, every time my WoW client boots, it tells me I have out-of-date addons (if I have enabled any at all), and it will ask me to either allow loading them again, or disable all of them (which turns off ALL addons for some weird reason). I find the pop up every single time rather annoying, if it was a one-off, sure, not a problem, but ticking that "load out of date addons" box doesn't prevent the pop up.

Wait a minute, is this how it works nowadays?

I'm quite sure it is. I've taken a few other addons as examples and then tested the changes myself. The game interface version is likely to stay at the current value for a long time, due to it already being developed before and such.

My point of view of the whole issue is that the nag is a ridiculously stupid thing, which you can simply disable with literally a single click. But if the nag is getting re-enabled and the error message keeps happening over and over again, then it's definitely something to look into.

I agree with your point of view on this, but sadly, it keeps getting re-enabled for me (and apparently other users as well)