anzz1 / TacoTip

Better player tooltips - class colors, talents/specialization, GearScore & more - for Classic / TBC / WoTLK
8 stars 19 forks source link

Added spell id for new WOTLK Paladin Glyph: Glyph of Reckoning #36

Closed Jakobud closed 1 year ago

Jakobud commented 1 year ago

There is a new bug introduced into LibClassicInspector because a new Glyph was added to WOTLK for Ret paladins:

https://www.wowhead.com/wotlk/spell=405004/glyph-of-reckoning

This bugfix, fixes the error. Simply added the proper glyph spell ID to the table.

Here is the error in question.

16x ...Tip/Libs/LibClassicInspector-9/LibClassicInspector.lua:3102: attempt to perform arithmetic on field '?' (a nil value)
[string "@TacoTip/Libs/LibClassicInspector-9/LibClassicInspector.lua"]:3102: in function <...Tip/Libs/LibClassicInspector/LibClassicInspector.lua:3083>
[string "@TacoTip/Libs/LibClassicInspector-9/LibClassicInspector.lua"]:3160: in function <...Tip/Libs/LibClassicInspector/LibClassicInspector.lua:3156>

Locals:
s = "01-1000000000300000000000000000042000000003000050000012023053512120023103331203123000000000000000000000000003350231103050233152312312200500003120220000000000000145D2"
(for index) = 1
(for limit) = 2
(for step) = 1
x = 1
(for index) = 6
(for limit) = 6
(for step) = 1
i = 6
z = 405004
(*temporary) = "01-1000000000300000000000000000042000000003000050000012023053512120023103331203123000000000000000000000000003350231103050233152312312200500003120220000000000000145D2"
(*temporary) = <function> defined =[C]:-1
(*temporary) = nil
(*temporary) = true
(*temporary) = true
(*temporary) = true
(*temporary) = true
(*temporary) = true
(*temporary) = nil
(*temporary) = true
(*temporary) = "nil"
(*temporary) = <function> defined @SharedXML/InterfaceUtil.lua:5
(*temporary) = "attempt to perform arithmetic on field '?' (a nil value)"
isWotlk = true
glyph_r_tbl = <table> {
 63219 = 23
 63223 = 26
 63225 = 28
 57937 = 1
 54923 = 2
 54925 = 4
 54927 = 6
 54929 = 8
 54931 = 10
 54935 = 12
 54937 = 14
 54939 = 16
 54943 = 18
 57979 = 6
 63218 = 22
 63220 = 24
 63222 = 25
 63224 = 27
 54922 = 1
 54924 = 3
 54926 = 5
 54928 = 7
 54930 = 9
 54934 = 11
 54936 = 13
 54938 = 15
 54940 = 17
 57958 = 5
 57955 = 4
 57954 = 3
 57947 = 2
 56416 = 20
 56420 = 21
 56414 = 19
}
SendAddonMessage = <function> defined =[C]:-1
C_PREFIX = "LCIV1"
anzz1 commented 1 year ago

Fixed in 0.3.6 . Couldn't test it right now but I reckon it should be fixed now. Thank you for your contribution, and I'll get around to checking out the other PRs/issues later when I'm able to.

BorniPL commented 1 year ago

Do you think it's the same issue we're having right now in Phase3, @Jakobud ? I've submitted an issue - it looks similar at the first glance.

anzz1 commented 1 year ago

I think this has been fixed. Closing, but feel free to reopen if the issue arises again.

Jakobud commented 1 year ago

I haven't seen an errors like this. Paladins didn't have any new Glyphs added. I know that Warriors did though. Glyph of Shattering Throw was added.