aoberoi / opentok-titanium

Titanium module for using Opentok iOS SDK
Other
4 stars 7 forks source link

Support iOS 8 #16

Open jwcao opened 10 years ago

jwcao commented 10 years ago

Hi, Ankur

In the past we've been able to support new versions of iOS by simply recompiling your builds against the latest iOS sdk and Titanium build. It looks like with the latest Opentok iOS sdk that supports iOS 8 there are some api changes though, and your Titanium module isn't building for me.

Do you have any plans to update the Titanium module to support iOS 8 and the latest Opentok sdk?

Thanks for the work you do with this.

kosso commented 9 years ago

Even the example doc which was at https://tokbox.com/opentok/api/tools/ios/tutorials/ios_titanium.html no longer exists.

Does this module still work with the latest Titanium 3.4.0 and latest OpenTok libraries?

jwcao commented 9 years ago

I was able to get it to work. I did have to make a few code changes though, since the Opentok API had some methods that no longer existed, or took additional parameters. I don't know objective-c at all, so they were fairly straightforward changes to get it compiling.

kosso commented 9 years ago

Hi @jwcao

I managed to rebuild the module zip against the Ti 3.4.0.GA SDK but I'm still getting app build failures when I include it. (Also providing the extra OTAssetBundlePath in tiapp.xml)

Do you have a fork anywhere with working code I could check out at all please?

Cheers :)

kosso commented 9 years ago

@jwcao : Hi again.

Was this the same build error that you overcame?

[ERROR] :  2014-11-11 14:41:47.553 xcodebuild[91115:35472773]  DeveloperPortal: Using pre-existing current store at URL (file:///Users/kosso/Library/Developer/Xcode/DeveloperPortal%206.1.db).
[ERROR] :  ** BUILD FAILED **
jwcao commented 9 years ago

I don't have it on a public repo. It's something I've been meaning to do, since I have a working Android module. In the mean time, you can grab the source from here:

[removed]

Please tell me once you grab it so I can remove that link.

I couldn't get Titanium to pass the api key and session id together, and then get that information in the objective-c, so I hard-coded the api key in session proxy. So you'll need to add your own in that file.

Thanks

kosso commented 9 years ago

Got it. Perfect. Thanks :)

I'll have a poke around at this.

aoberoi commented 9 years ago

hey guys, sorry for my absence in the thread. my intention is to revisit this module and tighten it up for use with the latest WebRTC versions of the OpenTok library (currently 2.3.1). this will be a personal project and not supported by TokBox.

i'm really happy you both have interest in the module, that motivates me to work on it more urgently. in the meantime, i ask that you keep reporting issues and also try to share any workarounds you might find. if we work together, this module can return to high quality more quickly.

@jwcao i can't see what the changes you made since you already removed the link, but if you get a chance to fork this repo, make some edits, and send a Pull Request my way, i would greatly appreciate it.

@kosso the error related to the database or store that you quoted above is not related to this module. if you have a sample that you believe should be working and is not, please file a new issue with that sample zipped up and links so that I can inspect it.

kosso commented 9 years ago

Hi. I'll check back later. I'm actually just off out to a 'developer challenge' meetup tonight based around webRTC and TokBox ;)

http://www.meetup.com/Simpleweb-Hack-Day/events/212432822/?_af_eid=212432822&_af=event&a=uc1_te

I did manage to get a successful build of the module, but with some errors and warnings

Users/kosso/ti_modules/opentok-titanium-master/Classes/ComTokboxTiOpentokPublisherProxy.m:56:13: warning: enumeration value 'AVCaptureDevicePositionUnspecified'
      not handled in switch [-Wswitch]
    switch (position) {
            ^
1 warning generated.

others who have reported the same database error in their apps have discovered that there are old modules causing it, since the most recent Ti SK versions.

kosso commented 9 years ago

Roland says hi! ;)

aoberoi commented 9 years ago

@kosso sounds like it was a fun hack night :grinning:

yozef commented 9 years ago

Any update for Ti SDK 3.5.1.GA? (module must be 64-bit).

rollsroyc3 commented 9 years ago

Is this module still under any active development?

aoberoi commented 9 years ago

@rollsroyc3 unfortunately i can't dedicate much time to active development. i'd be willing to hand over to someone else if they stepped up, and even to sit down and work more actively over the time it takes to transition the knowledge. at the very least i can commit to reviewing pull requests and testing changes.

i keep the project around because many people has said it has helped them even in its current form. if you also find it useful and need it to be actively worked on, maybe we can discuss your needs specifically.

yozef commented 9 years ago

I am sure there are interest for this module. Maybe a small team can form to take this on. I find it odd that @opentok hadn't adopted the project.

kosso commented 9 years ago

Will the code in this repo work with the latest OpenTok iOS SDK "2.3.+" Framework files ? Or is it totally incompatible?

https://tokbox.com/opentok/libraries/client/ios/

jwcao commented 9 years ago

I have working modules for iOS and Android using the latest Opentok and Titanium SDKs. I just need to stop being lazy and fork it. I think I'll have some time tomorrow morning to do it.

rollsroyc3 commented 9 years ago

@jwcao that would be incredibly helpful, I look forward to checking it out..

jwcao commented 9 years ago

Okay, forked here...

https://github.com/jwcao/opentok-titanium

Let me know if you have any issues.

yozef commented 9 years ago

Thanks @jwcao

rollsroyc3 commented 9 years ago

@jwcao thanks for the upload, following your instructions the iOS build failed. It was complaining about the file ComTokboxTiOpentok_Prefix.pch with the following error:

clang: error: no such file or directory: '/Users/andrewroyce/Downloads/opentok-titanium-master/ios/ComTokboxTiOpentok_Prefix.pch'

I went ahead and grabbed that file from the other project and included that in root and that seems to have done the trick.

jwcao commented 9 years ago

@rollsroyc3 .pch was in my global git ignore, so just added it. Thanks.