search

aodn / aatams

Animal Tracking (formerly AATAMS)
https://aatams.aodn.org.au
8 stars 3 forks source link

Google analytics script is served for non-production instances #370

Closed julian1 closed 7 years ago

julian1 commented 7 years ago

eg. view-source:http://aatams-test-instance/aatams/. Tag id is the same as production.

ghost commented 7 years ago

Hardcoded in https://github.com/aodn/aatams/blob/master/grails-app/views/layouts/main.gsp#L111

Not sure the most appropriate way to extract it... Portal derives the per-environment value from config-managed (Chef or EB) Portal.groovy...

ghost commented 7 years ago

Templated based on presence/absence of tracking ID: https://github.com/aodn/aodn-portal/blob/master/grails-app/views/_google_analytics.gsp this could be ported over to here to work similarly?

julian1 commented 7 years ago

yes, that looks much better.

xhoenner commented 7 years ago

Can be closed @lwgordonimos?

anguss00 commented 7 years ago

Yes, I fixed this one @xhoenner. Closing