Address issue #396 - Githubissues

aodn / aatams

Animal Tracking (formerly AATAMS)

https://aatams.aodn.org.au

8 stars 3 forks source link

Closed xhoenner closed 7 years ago

xhoenner commented 7 years ago

Made Tag Expected Life Time in tag creation and edit pages mandatory. Could you please review this PR @bhasin85?

bhasin85 commented 7 years ago

@xhoenner Trigger the build again.... It should pass all the checks.

bhasin85 commented 7 years ago

Can you please update the branch again with Master.... Thanks :+1:

xhoenner commented 7 years ago

@bhasin85 I fixed up existing issues with unit tests and added in the tests you recommended. Thanks heaps for your kind help!

Similarly to https://github.com/aodn/aatams/pull/395, the Travis build failed due to an issue with postgis. The log also says:

The command "./init_test_db.sh" failed and exited with 1 during .

xhoenner commented 7 years ago

Both PRs have now passed all unit and integration tests @bhasin85 so it'd be great if you could review those in the next few days.

bhasin85 commented 7 years ago

@xhoenner This one looks good. Thanks for fixing it up. :+1:

giphy

xhoenner commented 7 years ago

I never thought it'd be this painful to go through all those tests

giphy