aodn / aodn-portal

AODN Open Geospatial Portal
https://portal.aodn.org.au/
GNU General Public License v3.0
21 stars 13 forks source link

Zoom to layer sometimes gives incorrect zoom #1

Closed tojofo closed 11 years ago

tojofo commented 11 years ago

Dave Watts says: Added Argo Float as layer then did Zoom to layer using right click and I got a map of the Western hemisphere only (Bug_5.png). ANFOG Ocean Gliders made me visit the North Atlantic

tojofo commented 11 years ago

jonescc: Did some research on this issue. WMS 1.3.0 allows a minimal bounding box to be specified in terms of east west north south as per iso19115 metadata. This is probably intended to address exactly the issue we are having. Need to confirm that this can handle minimal bounding boxes crossing the anti-meridian (i.e. east < west) and support in geoserver.

jonescc commented 11 years ago

Ignore previous comment. Not related to minimal bounding boxes at all.

Retested in imos production portal and auto zoom to layer function and zoom to layer function correctly zooms to full map for argo float layer and to bounding box for anfog gliders.

kereid commented 11 years ago

[Portal Build Info] Base URL: http://rc.aodn.org.au/aodn Build date: 19/02/2013 15:24 Version: 2.35rc Instance name: AODN Environment: prerelease Build: #21 SVN revision: #Unk. SVN URL: Unk.

Steps to reproduce

Add the Argo floats measuring Oxygen layer to the map and then click the magnifying glass zoom in the active layers box.

What should happen

Zooms to layer on map

What does happen: Taken to look at Africa.

Although I'm not sure if it is this exact bug as it does only seem to occur for Argo layers and no others (that I could find)

jonescc commented 11 years ago

Argo layer has disappeared. Looks like the nfs mount was unavailable last time the harvester ran. Rerunning harvester to restore layers so that this problem can be reproduced. Looks like an issue with zooming on filtered layers.

pblain commented 11 years ago

The missing argo harvest is not really related to the original bug. However, I made a change that is a workaround for the original bug. It allows the administrator to set a default bounding box that will be zoomed to when the user attempts to zoom to one of the offending layers. Someone should code review it. https://github.com/aodn/aodn-portal/commit/eef0d5b79f25197f6adda68928220f9d11d98d9d

jonescc commented 11 years ago

Reviewed. Some tests failing.

jonescc commented 11 years ago

Tests have been fixed and committed in dfe5b2daecdfa4c7c2bcf8065ef9086d371adddf

Fixes issues with trajectory layers such as soop CO2 where the trajectory is split programmatically at the anti-meridian resulting in -180/180 minimum/maximum longitude, but not for point data such as argo oxygen which Kate identified as being a problem layer above.

dnahodil commented 11 years ago

I'll review these test changes