search

aodn / aodn-portal

AODN Open Geospatial Portal
https://portal.aodn.org.au/
GNU General Public License v3.0
21 stars 13 forks source link

Download Cart Items link to THREDDS #145

Closed akashisama closed 11 years ago

akashisama commented 11 years ago

Steps to reproduce: Add an item to download cart Go to Download Cart Click on the File Description (eg "Link to download netCDF data file (text/html)"

What should happen: Nothing, users shouldn't be linked to any external site or file, we have a download button for downloading stuff.

What does happen: User gets taken to a THREDDS catalog page.

Additional: File descriptions should not include the words "link to download" since they should not be links.

pmbohm commented 11 years ago

// todo fix metadata first. Should we strip rubbish from titles? Markup as links when correctly flagged as such? Metadata shows data links as html and vice versa

dnahodil commented 11 years ago

Just one small change for the review. The Strings that make up the template were being passed to the XTemplate constructor inconsistently. I fixed that as it was only minor.

As for your todo comment, we will get complaints if we leave the titles as-is. The rubbish titles you mention make for terrible UX here. On the records I saw the procotol was WWW:LINK-1.0-http--downloaddata for the ones with the rubbish title. The others were WWW:DOWNLOAD-1.0-http--(something). So if that was consistent (might need to check w/ project officers) we could avoid the rubbish titles by first checking the protocol. What would we put there instead? I'm not sure.

dnahodil commented 11 years ago

Perhaps the text could say something like 'Unnamed link to data' or something?

pmbohm commented 11 years ago

I talked to Seb about the protocols. He'll get Craig to run a report on the 'data' links.

pmbohm commented 11 years ago

So bad 'protocol' and 'types' are coming from data links that are hosted on the datafabric. The datafabric is decomissioned and so the MEST is (most likely) harvesting error pages and setting the type to text/html

akashisama commented 11 years ago

Looks good. Reviewed, with the proviso that someone, probably not us, needs to do something about this MEST trying to harvest from datafabric business.