search

aodn / aodn-portal

AODN Open Geospatial Portal
https://portal.aodn.org.au/
GNU General Public License v3.0
21 stars 13 forks source link

Date picker calenders not limited to date range extent for non-ncWMS layers #1784

Closed pmbohm closed 8 years ago

pmbohm commented 9 years ago

Problem

The DateFilterPanel.js _setMinMax is never being utilised. Dates in the calender picker should be limited to the extent of the data

Solution

A Geoserver service is needed that can supply the data Min and Max date range.

dnahodil commented 9 years ago

Can I suggest we leave this until after the time filter has been 'globalised'?

The required behaviour will change at that point (all time ranges will need to be taken into account) and it's probably not worth fixing it twice.

dnahodil commented 8 years ago

Ming at TPAC (@fxmzb123) has spotted this issue and it is causing them problems. If the accordion work has been pushed back then we probably should fix this now. (I've re-added the 'bug' label accordingly, @pblain).

I think the problem comes from https://github.com/aodn/aodn-portal/blob/442355c1318504dba3e272fcdd4c9064e0a6d383/web-app/js/portal/filter/ui/DateFilterPanel.js#L32, which is the old way of populating values. We should look at ComboFilterPanel for an example of the new way. The needsFilterRange() function should return true and then we should have a setFilterRange() function which is given the filter range once it is loaded (example). One note: TPAC have datasets which project into the future so both the from- and to- dates need to support dates in the future.

pblain commented 8 years ago

Already in backlog: https://github.com/aodn/backlog/issues/62

smancini commented 8 years ago

This issue is still valid as it refers to non-ncWMS layer.

For ncWMS layer, dates in the calendar picker are updated and only show availalbe dates.

It is still not the case for non-ncWMS layers like for example Argo.

pblain commented 8 years ago

it's in aodn/backlog#62

smancini commented 8 years ago

Yes but aodn/backlog#62 is closed Should it be reopened?