Data collection refactoring

[jkburges]

General notes of things that are currently a bit messy and need to be refactored (in order of most to least importance):

1. visibility and life cycle of DataCollectionLayers
   • DataCollection.getLayerState()
   • DataCollection.getSelectedLayer()
   • DataCollectionLayers behaving as an OpenLayer
2. ref FilterService:20 - hide the fact that filters are retrieved from a single layer in geoserver. As far as the portal is concerned, it should be modelled as filter per data collection
3. Remove usages of bodaacFilterParams (unblocks more refactoring opportunities)
4. Search and replace for GeoNetwork -> Metadata (unless it really is geonetwork specific code)
5. search for this.layer - check for using layer instead of DataCollection
6. unit tests for DataCollection, DataCollectionStore, DataCollectionLayers
7. layer link vs layer record vs open layer vs converted layer link e.g. https://github.com/aodn/aodn-portal/pull/1868/files#diff-c77abb48bd68b441f485ece546efd3dcR201
   • lifecycle
   • representation
8. naming SubsetPanel, SubsettingPanel, generally the component which are children of the filtering step
9. Portal.cart namespace
10. Move ncWMS params to use filters get/set on DataCollection
11. Rename Ncwms, NcWMS -> NcWms
12. Change usages of SELECTED_LAYER_CHANGED to DataCollection-held event
13. Move DataCollection updateFilters() out of DataCollection - no setFilters(), either
14. DataCollectionStore
    • getLoadedRecords(?)
    • isRecordActive()
    • getRecordForUuid()
15. Active record stuff from FacetedSearchResultsDataView
16. Rename DATA_COLLECTION_MODIFIED -> DATA_COLLECTION_STATE_CHANGED
17. Combine or abolish LayerDescriptor, LayerOptions, and LayerParams

[dnahodil]

I'm looking at number 2

[dnahodil]

PR #1882 addresses number 2

[dnahodil]

All the important refactorings here have been done!

[jkburges]

:+1: :+1: