General notes of things that are currently a bit messy and need to be refactored (in order of most to least importance):
visibility and life cycle of DataCollectionLayers
DataCollection.getLayerState()
DataCollection.getSelectedLayer()
DataCollectionLayers behaving as an OpenLayer
ref FilterService:20 - hide the fact that filters are retrieved from a single layer in geoserver. As far as the portal is concerned, it should be modelled as filter per data collection
Remove usages of bodaacFilterParams (unblocks more refactoring opportunities)
Search and replace for GeoNetwork -> Metadata (unless it really is geonetwork specific code)
search for this.layer - check for using layer instead of DataCollection
unit tests for DataCollection, DataCollectionStore, DataCollectionLayers
General notes of things that are currently a bit messy and need to be refactored (in order of most to least importance):
visibility and life cycle ofDataCollectionLayers
DataCollection.getLayerState()
DataCollection.getSelectedLayer()
DataCollectionLayers
behaving as an OpenLayerref FilterService:20 - hide the fact that filters are retrieved from a single layer in geoserver. As far as the portal is concerned, it should be modelled as filter per data collectionRemove usages of bodaacFilterParams (unblocks more refactoring opportunities)Search and replace for GeoNetwork -> Metadata (unless it really is geonetwork specific code)search forthis.layer
- check for using layer instead of DataCollectionunit tests for DataCollection, DataCollectionStore, DataCollectionLayerslayer link vs layer record vs open layer vs converted layer linke.g. https://github.com/aodn/aodn-portal/pull/1868/files#diff-c77abb48bd68b441f485ece546efd3dcR201lifecyclerepresentationnaming SubsetPanel, SubsettingPanel, generally the component which are children of the filtering stepMove ncWMS params to use filters get/set on DataCollectionRename Ncwms, NcWMS -> NcWmsChange usages of SELECTED_LAYER_CHANGED to DataCollection-held eventDataCollectionStoregetLoadedRecords(?)isRecordActive()getRecordForUuid()Active record stuff from FacetedSearchResultsDataViewRename DATA_COLLECTION_MODIFIED -> DATA_COLLECTION_STATE_CHANGED