search

aodn / aodn-portal

AODN Open Geospatial Portal
https://portal.aodn.org.au/
GNU General Public License v3.0
21 stars 13 forks source link

Some layers with diver platform have empty platform row in results #2502

Closed akashisama closed 7 years ago

akashisama commented 7 years ago

Steps to reproduce:

In the platform facet expand "Biological platform" and select "diver".

What should happen:

All results contain "Biological platform" in the platform row.

What does happen:

"Mapping of selected areas of Cockburn Sound, Western Australia", "Habitat Maps derived from Point Lookout Ecological Surveys (PLEA)" and "Ecophysiology of three habitat-forming seaweeds across a depth and latitudinal gradient in southeastern Australia" are missing the platform row.

kereid commented 7 years ago

Had a chat to Nat and might possibly have something to do with the Metadata containing a short name and the portal not handling but that's just a guess otherwise not sure why.

eflukes commented 7 years ago

?Just saw this pop up - I've checked out both those layers as they're both coming from us (IMAS).

For this layer: "Ecophysiology of three habitat-forming seaweeds across a depth and latitudinal gradient in southeastern Australia?", I couldn't reproduce the issue described. Biological platform is showing as expected - please let me know if I've missed something.

The other two layers (Cockburn Sound, Point Lookout) are now functioning as expected in the IMAS Data Portal, and should be fixed in the AODN Portal on next harvest. Initially I thought the issue occurred because both layers have multiple instances of the same data parameter ("Biotic taxonomic identification" for Cockburn Sound, "Benthic physical habitat" (freetext) for Point Lookout) collected using different platforms, but actually that's not the case. The missing platform row was because the portal only displays a single platform result at Step 1.

For example: if a layer contains "Temperature of the water body" collected by a research vessel as Data Parameter #1 and "Abundance of biota" collected by a diver as Data Parameter #2, only the first chronological instance of a platform ("research vessel") is displayed.? In this case, the first instance of a data parameter was not associated with a platform from the controlled vocabulary, so the portal returned a blank row. I've worked around this by re-ordering the data parameters in these two records.

The issue becomes more complicated again if a single data parameter is collected using multiple different platforms. e.g. for "Mapping of selected areas of Cockburn Sound, Western Australia", the data parameter "Biotic taxonomic identification" was collected in 4 different ways, using 3 different platforms (aerial photographs from light aircraft, underwater cameras from research vessel, sidescan sonar from research vessel, transects by divers). Each of those 4 methods, and 3 platforms, was used to measure a single parameter - ie taxonomic identification of seagrass species. However, only the first platform is displayed at Step 1, so you're potentially missing out on displaying useful information. Moreover, if the platform doesn't currently exist in the AODN Platform vocab, suddenly the ordering of data parameters in the metadata influences how the record displays in the Portal (which is possibly not intentional).

It's totally up to you guys if you want to raise this as a bug or feature request - just thought I'd let you know :-)

Dr EMMA FLUKES NESP MBH Data Manager | IMAS Research Data Analyst

NESP Marine Biodiversity Hub | Institute for Marine and Antarctic Studies (IMAS) University of Tasmania Office: IMAS Waterfront Building (113.21), 20 Castray Espl, Battery Point Mail: University of Tasmania, Private Bag 129, HOBART TAS 7001 M +61408 901 952 www.nespmarine.edu.au | www.imas.utas.edu.au

IMAS - in partnership with the Tasmanian State Government

From: kereid notifications@github.com Sent: Wednesday, 21 June 2017 2:35 PM To: aodn/aodn-portal Cc: Subscribed Subject: Re: [aodn/aodn-portal] Some layers with diver platform have empty platform row in results (#2502)

Had a chat to Nat and might possibly have something to do with the Metadata containing a short name and the portal not handling but that's just a guess otherwise not sure why.

- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/aodn/aodn-portal/issues/2502#issuecomment-309960569, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMQokzRsYAzeKHDZUN4TPgnLuGCGA3aBks5sGJ2lgaJpZM4OAXhZ.

University of Tasmania Electronic Communications Policy (December, 2014). This email is confidential, and is for the intended recipient only. Access, disclosure, copying, distribution, or reliance on any of it by anyone outside the intended recipient organisation is prohibited and may be a criminal offence. Please delete if obtained in error and email confirmation to the sender. The views expressed in this email are not necessarily the views of the University of Tasmania, unless clearly intended otherwise.

atkinsn commented 7 years ago

Thanks @eflukes for the excellent investigation

akashisama commented 7 years ago

Oh wow, that was fast. Looks like I must have been going crazy with that third layer.

kereid commented 7 years ago

Bug notes - platform should be discoverable from metadata regardless of preceeding empty platform elements, OR platform should be discoverable from metadata regardless of preceeding non-vocab element i.e. just text

kereid commented 7 years ago

Thanks @eflukes. Nat and I have discussed and come up with the following:

This bug will remain open see above comment.

We have opened a backlog item https://github.com/aodn/backlog/issues/648 to cover showing multiple plaforms on step 1 of the portal.

Regarding new platform entries they need to be submitted to Nat to enter into the AODN vocab otherwise they aren't recognised in the facets, so please supply a list of current missing terms.

kereid commented 7 years ago

Not sure why I got assigned I can't fix a portal bug.

pblain commented 7 years ago

@kereid - feel free to close it. There's a backlog item for it right? Or is there some other reason to keep it open?

kereid commented 7 years ago

It is a bug that needs to be fixed. The backlog is a different issue (a feature request) that was discovered through the reporting of the bug.

pblain commented 7 years ago

@kereid (and @akashisama ) - OK so you're referring to this : https://github.com/aodn/aodn-portal/issues/2502#issuecomment-310231407. Is this correct? It might be worth writing a new bug description below so it's a bit clearer to the person who picks this up. I say this because the "steps to reproduce" no longer result in the issue. You can also assign it to me.

kereid commented 7 years ago

@pblain, ah right with you now, yes it's fixed in production because Emma manually fixed the records that we found the issue on.

@atkinsn has created a test record in RC to demonstrate http://portal-rc.aodn.org.au/search?uuid=fedd2f8d-03f1-45a2-b48d-13b015fa7839

Steps to reproduce:

In the platform facet expand "biological platform" and select "diver"

What should happen:

The result contains "biological platform" in the platform row

What does happen:

Collection is missing the row, because the portal only looks at the first platform in the metadata and if it is not valid does not continue on to find the next valid one