aodn / aodn-portal

AODN Open Geospatial Portal
https://portal.aodn.org.au/
GNU General Public License v3.0
21 stars 13 forks source link

layer contour option is wrong #2665

Closed ocehugo closed 6 years ago

ocehugo commented 6 years ago

How to Reproduce:

  1. Select HF Radar (say WA).
  2. Zoom into the area.
  3. Select layer tab in step 2.
  4. Select any contour/colormap option.

Result:

  1. Contours will be pixelated, not smoothed.
  2. Contours will barely visible and with a fixed colour (grayish) instead of a colormap.

Expected:

  1. Smoothed contours.
  2. Coloured contours.

Browser: Chrome/Linux screenshot-1

ggalibert commented 6 years ago

From the GODIVA interface (uses ncWMS) one can indeed see that the contour is being smoothed, however it is not being coloured. I don't think we could have it coloured.

Example with boxfill: http://thredds.aodn.org.au/thredds/wms/IMOS/ACORN/gridded_1h-avg-current-map_QC/ROT/2017/12/31/IMOS_ACORN_V_20171231T233000Z_ROT_FV01_1-hour-avg.nc?LAYERS=VCUR&ELEVATION=0&TIME=2017-12-31T23%3A30%3A00.000Z&TRANSPARENT=true&STYLES=boxfill%2Frainbow&COLORSCALERANGE=-1%2C1&NUMCOLORBANDS=250&LOGSCALE=false&SERVICE=WMS&VERSION=1.1.1&REQUEST=GetMap&EXCEPTIONS=application%2Fvnd.ogc.se_inimage&FORMAT=image%2Fpng&SRS=EPSG%3A4326&BBOX=113.15197,-33.433849,115.741219,-30.150743&WIDTH=256&HEIGHT=256

imos_acorn_v_20171231t233000z_rot_fv01_1-hour-avg nc

Same example with contour: http://thredds.aodn.org.au/thredds/wms/IMOS/ACORN/gridded_1h-avg-current-map_QC/ROT/2017/12/31/IMOS_ACORN_V_20171231T233000Z_ROT_FV01_1-hour-avg.nc?LAYERS=VCUR&ELEVATION=0&TIME=2017-12-31T23%3A30%3A00.000Z&TRANSPARENT=true&STYLES=contour%2Frainbow&COLORSCALERANGE=-1%2C1&NUMCOLORBANDS=250&LOGSCALE=false&SERVICE=WMS&VERSION=1.1.1&REQUEST=GetMap&EXCEPTIONS=application%2Fvnd.ogc.se_inimage&FORMAT=image%2Fpng&SRS=EPSG%3A4326&BBOX=113.15197,-33.433849,115.741219,-30.150743&WIDTH=256&HEIGHT=256

imos_acorn_v_20171231t233000z_rot_fv01_1-hour-avg nc contour

ggalibert commented 6 years ago

@jonescc correct me if I'm wrong but these discrepencies might come from different versions of ncWMS in current THREDDS and ncWMS abomination.

ggalibert commented 6 years ago

Looks like newer version of ncWMS do not smooth contour anymore: https://github.com/Reading-eScience-Centre/ncwms/issues/10 . ncWMS now makes use of EDAL which has implemented this behaviour https://github.com/Reading-eScience-Centre/edal-java/issues/12

This problem might not be in our hands unfortunately.

pblain commented 6 years ago

Moved here: https://github.com/aodn/content/issues/350 (I think it's more content related)

ggalibert commented 6 years ago

@pblain I don't think this is a content issue. I asked @jonescc what he thinks about this but I think the expected result is tied to what ncWMS decide to do and which version of ncWMS we use.

Contrary to @ocehugo I don't think the expected contour should be smoothed anyway (the original data is not smoothed) and this same decision has been decided in newest ncWMS.

As to colour of contour, it might be a good idea but again it's in ncWMS hands and this is probably a detail of low priority.

Overall, I'm happy to leave this issue closed.

pblain commented 6 years ago

@ggalibert OK- that makes sense. I'll tag as "won't fix". We can revisit it depending on what happens with ncWMS.