search

aodn / aodn-portal

AODN Open Geospatial Portal
https://portal.aodn.org.au/
GNU General Public License v3.0
21 stars 13 forks source link

Do we need both Gutter and wrapDateLine? #33

Closed akashisama closed 11 years ago

akashisama commented 11 years ago

Right now we set gutter = 20 and wrapDateLine= true for each layer. Problem is this is causing the same problem for us as the guy here: https://github.com/openlayers/openlayers/issues/457

Does anyone know if we have a particular reason for setting these or if they were just added for the sake of it?

Best solution seems to be to unset one of them.

*this is related to a redmine support issue, not in github issues, but this seems like a good place to ask a team wide question.

@aodn/owners

jkburges commented 11 years ago

IIRC - wrapDateLine is for continuous panning E/W - and as a result, for example, you can see the whole Pacific Ocean on the screen at once (without it, you cannot).

On 10 December 2012 16:16, Alex McKeown notifications@github.com wrote:

Problem is this is causing the same problem for us as the guy here:

dnahodil commented 11 years ago

I think the gutter option makes moving around the map a bit more responsive.

jkburges commented 11 years ago

I think the gutter option makes moving around the map a bit more responsive.

Yes, I remember now that that means that tiles that just outside the visible area are "eagerly" loaded, so that when panning they are visibile immediately.

paulinemak commented 11 years ago

HI all,

I thought the gutter setting was for individual images -- I've changed that a little while ago because it was chopping off symbols between vector tiles (i.e., ncWMS images that draws arrows for directions). The documentation says:

"{Integer} Determines the width (in pixels) of the gutter around image tiles to ignore. By setting this property to a non-zero value, images will be requested that are wider and taller than the tile size by a value of 2 x gutter. This allows artifacts of rendering at tile edges to be ignored. Set a gutter value that is equal to half the size of the widest symbol that needs to be displayed. Defaults to zero. Non-tiled layers always have zero gutter."

I think the setting for eagerly grab extra tiles is called something else, but nothing is popping up from a quick glance over the docco.

Cheers,

-Pauline.

From: jkburges [notifications@github.com] Sent: Monday, December 10, 2012 4:23 PM To: aodn/aodn-portal Cc: Pauline Mak Subject: Re: [aodn-portal] Do we need both Gutter and wrapDateLine? (#33)

I think the gutter option makes moving around the map a bit more responsive.

Yes, I remember now that that means that tiles that just outside the visible area are "eagerly" loaded, so that when panning they are visibile immediately.

— Reply to this email directly or view it on GitHubhttps://github.com/aodn/aodn-portal/issues/33#issuecomment-11182341.

jkburges commented 11 years ago

Oh yeah that sounds right Pauline, I was confused, obviously.

On 10 December 2012 18:08, paulinemak notifications@github.com wrote:

HI all,

I thought the gutter setting was for individual images -- I've changed that a little while ago because it was chopping off symbols between vector tiles (i.e., ncWMS images that draws arrows for directions). The documentation says:

"{Integer} Determines the width (in pixels) of the gutter around image tiles to ignore. By setting this property to a non-zero value, images will be requested that are wider and taller than the tile size by a value of 2 x gutter. This allows artifacts of rendering at tile edges to be ignored. Set a gutter value that is equal to half the size of the widest symbol that needs to be displayed. Defaults to zero. Non-tiled layers always have zero gutter."

I think the setting for eagerly grab extra tiles is called something else, but nothing is popping up from a quick glance over the docco.

Cheers,

-Pauline.

From: jkburges [notifications@github.com] Sent: Monday, December 10, 2012 4:23 PM To: aodn/aodn-portal Cc: Pauline Mak Subject: Re: [aodn-portal] Do we need both Gutter and wrapDateLine? (#33)

I think the gutter option makes moving around the map a bit more responsive.

Yes, I remember now that that means that tiles that just outside the visible area are "eagerly" loaded, so that when panning they are visibile immediately.

— Reply to this email directly or view it on GitHub< https://github.com/aodn/aodn-portal/issues/33#issuecomment-11182341>.

— Reply to this email directly or view it on GitHubhttps://github.com/aodn/aodn-portal/issues/33#issuecomment-11183683.

dnahodil commented 11 years ago

If this is per-layer then should the vector tiling layers have a gutter set and the ship tracks and similar not have it set?

paulinemak commented 11 years ago

Sounds like a good idea. On another note, setting gutter to baselayers completely stuffs them up, so there was a bit of code there to exclude them. This will be (yet another) layer setting in the portal I take it? Unless if there's something in the style that we can extract to see if they are using symbols. Certainly in ncWMS, all vector styles have names like "vector/". Not sure if geonetwork has something similar.

dnahodil commented 11 years ago

Is it not set by GeoServer?

paulinemak commented 11 years ago

Yes, but I think styles could be named as anything, I don't believe there's a convention... Craig may know a bit more about this, perhaps SLDs do specify if they will be a symbol or just continuous colours? Or can we just assume ALL tiles from geoserver will have symbols. Note that in the portal, we currently do not have a way to specify if a server is a geoserver (only distinguishes ncWMS).

akashisama commented 11 years ago

Closing since original question has been answered.