search

aodn / aodn-portal

AODN Open Geospatial Portal
https://portal.aodn.org.au/
GNU General Public License v3.0
21 stars 13 forks source link

Portal fails with WMS and TIME values which have decimals in file #387

Closed ggalibert closed 11 years ago

ggalibert commented 11 years ago

I cannot manage to display any layer from the Australian weekly CARS2009 Climatology.

This is the NCW request sent to the server by the portal :

http://ncwms.aodn.org.au/ncwms/wms?LAYERS=CARS_2009_Australia_Weekly%2FTEMP&TRANSPARENT=TRUE&VERSION=1.1.1&FORMAT=image%2Fpng&QUERYABLE=true&EXCEPTIONS=application%2Fvnd.ogc.se_xml&SERVICE=WMS&REQUEST=GetMap&STYLES=&SRS=EPSG%3A4326&BBOX=111.62109375,-34.62890625,124.62890625,-21.62109375&WIDTH=296&HEIGHT=296&TIME=2009-10-23T14:46:09

which doesn't work while this one does :

http://ncwms.aodn.org.au/ncwms/wms?LAYERS=CARS_2009_Australia_Weekly%2FTEMP&TRANSPARENT=TRUE&VERSION=1.1.1&FORMAT=image%2Fpng&QUERYABLE=true&EXCEPTIONS=application%2Fvnd.ogc.se_xml&SERVICE=WMS&REQUEST=GetMap&STYLES=&SRS=EPSG%3A4326&BBOX=111.62109375,-34.62890625,124.62890625,-21.62109375&WIDTH=296&HEIGHT=296&TIME=2009-10-23T14:46:09.230

With the time decimals from the file fully preserved and included in the request. It looks like the portal doesn't keep these decimals.

Thanks.

Guillaume

ggalibert commented 11 years ago

As a general remark, it would be great if the author of an issue could be consulted before closing it. :-)

Thanks

jkburges commented 11 years ago

I think this demonstrates a bit of a shortcoming of github issue tracking. I assume this bug has been fixed in master but not been deployed yet - @ggalibert where were you testing?

In bug trackers I have used previously, it's usual for the development team to mark a bug as "resolved" or some such, and then QA to mark it as "closed" if they indeed agree that it's fixed and been deployed to production.

In any case, I agree with Guillaume that it's not great that us developers are closing bugs.

ggalibert commented 11 years ago

I have checked the fix with Dan and agree to close the issue :-)

Thanks

dnahodil commented 11 years ago

Yeah GitHub issues is not a great tool, and we're not using it terribly well, ourselves.

pblain commented 11 years ago

How about a resolved tag - and a rule by convention that developers don't close bugs?

danfruehauf commented 11 years ago

I personally think bugs should be closed/resolved/verified during the QA process. So once the QA iteration starts, first thing is to make sure all the bugs that are marked as fixed - were actually fixed.

dnahodil commented 11 years ago

In the ideal world devs should mark an issue as fixed/resolved and the QA team should close it when it's been verified. If we wanted to have that sort of process then we'd need to be pretty clear about what the process is and who should make what changes (adding/changing tags, closing issues). GitHub Issues does not provide this sort of control or workflow so we'd need to be disciplined.

jkburges commented 11 years ago

How about we use...redmine?! Just kidding (well, not really).

dnahodil commented 11 years ago

@ggalibert: http://imos.aodn.org.au/imos/snapshot/loadMap/20683544

pblain commented 11 years ago

OK, something else for the retro. I think this is pretty important. Developers should definitely not be closing bugs. It is something that started happening after the move to github issue tracking. But easily put right if everyone is aware of the correct process. I'll inform our scrum master :-)