search

aodn / aodn-portal

AODN Open Geospatial Portal
https://portal.aodn.org.au/
GNU General Public License v3.0
21 stars 13 forks source link

Filter panel should have check box not radio buttons for O2 and SWT options #583

Closed pblain closed 11 years ago

pblain commented 11 years ago 
[Portal Build Info]
Base URL:      http://123.aodn.org.au/aodn123
Build date:    17/10/2013 13:40
Version:       3.4.0-rc2
Instance name: AODN
Environment:   prerelease

Steps to reproduce:

  1. Select Argo

What happens:

  1. On Step Two there are two radio buttons for oxygen (true and false)

What should happen: 1 There should be a checkbox. When checked the portal displays only profiles with oxygen. When unchecked all profiles are displayed.

kereid commented 11 years ago

Changing name from Download error for seals.

Also I see these same options on SOOP not sure if it's a generic fix for all filter panels so adding to this bug, if not someone let me know and I'll open a separate bug. Or if it's meant to be like that then it's not clear what the filter does and I will make a note to add it to the help.

jonescc commented 11 years ago

Radio buttons are currently used for all boolean filters, so this is a generic change for all boolean filters by the sounds of it.

Note that its currently possible to filter

a) all profiles measuring oxygen (true button selected) b) all profiles which don't measure oxygen (false selected) c) all profiles regardless of whether they measure oxygen or not (neither button selected).

Just to clarify, if the checkbox is checked that would be equivalent to option a) and if its not option c)?

jonescc commented 11 years ago

Actually, @pblain explicitly states that it is option c) above - ie. option b) is not required.

pblain commented 11 years ago

That's correct. We'll add a different filter type if there is ever a need for option b)