search

aodn / aodn-portal

AODN Open Geospatial Portal
https://portal.aodn.org.au/
GNU General Public License v3.0
21 stars 13 forks source link

Pan control should be default if no filters for a collection #735

Closed kereid closed 10 years ago

kereid commented 10 years ago

Portal 123 on Firefox

Steps to reproduce

Add collection until find one that does not load correctly, SOOP XBT is usually a sure thing. Click to move map

What should happen

Map can be moved

What does happen

Bounding box is still available to draw and just looks strange when there aren't any filters.

pmbohm commented 10 years ago

I suggest we don't work on this until the backlog tasks changes are implemented this iteration, as default behaviour is going to change anyhow. A Layer that does not load correctly is also something we shouldn't see in production and is not the norm unlike currently.

pmbohm commented 10 years ago

Time boxing my attempted solution to hide artifacts of misconfigured collections (layers) being added to the map.

On failure of the 'getFiltersAsJSON' ajax request the layer filters are faked: eg: layer.filters = [{name: "position", type: "BoundingBox", value: "none"}];

Then calling polygonTypeCombo.setValue if there was a intialConfig value supplied.

My coding resulted in other bugs after a days work so i'm timeboxing it. Also other bbox work by Angus may offer a cleaner starting point.

anguss00 commented 10 years ago

Closed as is contrary to acceptance criteria for no default bbox - the bbox drawing contrast must be active when the user reaches step 2