Closed ggalibert closed 8 years ago
@ggalibert Looks good. Any chance you could add a unit test for this util function?
@mhidas I have included your suggestions. Modification in imos_variable_test.nc are:
ggalibert@10-nsp-mel:~/compliance-checker$ ncDiff.sh /tmp/imos_variable_test.nc compliance_checker/tests/data/imos_variable_test.nc
32a33,34
> byte bad3_qc ;
> bad3_qc:quality_control_conventions = "unconventional" ;
55a58,59
>
> bad3_qc = -127 ;
:+1:
…as being an enough evidence of a variable being a quality control one. Replaced by the presence of a quality_control_conventions variable attribute.