search

aodn / content

Tracks AODN Portal content and configuration issues
0 stars 0 forks source link

ANMN AM - TEMP long_name att should use spaces instead of underscores #386

Closed ocehugo closed 5 years ago

ocehugo commented 5 years ago

AM files are inconsistent in the sense that we got:

TEMP 
long_name = sea_surface_temperature
standard_name = sea_surface_temperature

but

PSAL
long_name = sea surface salinity
standard_name = sea_surface_salinity

The problem: In PSAL spaces(underscores) are used for long_name(standard_name) attributes.

Blame files: all files in /AM/ therddds folder

mhidas commented 5 years ago

Actually by default we generally set the long_name to the same as standard_name (with underscores), if the latter exists. And even for those that don't have a standard_name, we often chose CF-like long_names that look similar, also w ith underscores (see e.g. the variable attributes written by the Matlab toolbox).

Also, long names are not meant to be standardised (otherwise they'd be standard_name!), so we've never imposed any constraints on them. Having said that, of course it's nice to have consistency, but in this case that means it's the PSAL long_names that would need updating to be consistent with the rest of the moorings data.

I assume this is for the delayed mode AM data?

ocehugo commented 5 years ago

@mhidas ,

yeap DM Mode. I understand the logic of standard vs long names. I just found that maybe this was a typo somewhere in the code pointing to the same string entry.

Feel free to close,rename/edit the issue if necessary

ocehugo commented 5 years ago

I also found that AM moorings are missing "instrument" global attribute. The keywords is also formatted very differently from other ANMN files.

ggalibert commented 5 years ago

I also found that AM moorings are missing "instrument" global attribute. The keywords is also formatted very differently from other ANMN files.

Please open a new issue for this. Also, I think we can close this one.