A couple of issues with python modules used by AIMS realtime scripts

aodn / data-services

Scripts which are used to process incoming data in the data ingestion pipeline

GNU General Public License v3.0

1 stars 4 forks source link

Closed mhidas closed 7 years ago

mhidas commented 7 years ago

While looking at #578 I noticed that the function pass_netcdf_checker seems to be imported from aims.realtime_util (in anmn_nrs_aims.py, faimms.py, and soop_trv.py) but that module in turn imports it from util.

Three minor issues with this:

Why isn't lib/aims/realtime_util.py under lib/python/ ?
It's generally a good idea to avoid from module import *
Why don't those scripts just import the pass_netcdf_checker directly from lib/python/util.py ?

lbesnard commented 7 years ago