search

aodn / geoserver-build

Configures a GeoServer war containing extensions and configuration required by AODN instances
Other
2 stars 4 forks source link

Potential for blocking on stdout or stderr during gogoduck timeseries processing #130

Closed jonescc closed 8 years ago

jonescc commented 8 years ago

https://github.com/aodn/geoserver-build/blob/master/src/extension/wps/src/main/java/au/org/emii/gogoduck/worker/CSVConverter.java#L101

There is a potential to block wating for stdout or stderr on completion of processing here (refer http://www.thecodingforums.com/threads/problems-getting-stderr-and-stdout-from-process-object.699309/ or other numerous posts on this issue). Use a well tested library to consume stdout/stderr from a system command such as apache commons exec pumpstreamhandler, redirect stderr to stdout (e.g. as per http://stackoverflow.com/questions/64000/draining-standard-error-in-java) or better yet rewrite in java so this is not required.

jonescc commented 8 years ago

Fixed by producing csv output in java in https://github.com/aodn/geoserver-build/pull/132