search

aodn / geoserver-build

Configures a GeoServer war containing extensions and configuration required by AODN instances
Other
2 stars 4 forks source link

Include TIME selection in thredds ncwms requests #133

Closed jonescc closed 8 years ago

jonescc commented 8 years ago

Enables support for datasets containing multiple times such as CARS

jonescc commented 8 years ago

DON'T MERGE - looking at some issues with CARS World Monthly time step selection

jonescc commented 8 years ago

Added an option to bypass forwarding the requested date and time onto thredds for collections which don't need to do so and where doing so would be problematic.

SRS has been indexed with date time values which don't match what thredds calculates meaning thredds rejects the date time requested as being invalid. The date time is not required to be passed on for SRS anyway as each SRS file only contains data for a single date time.

Will look at whether we should reharvest SRS with the correct date time information separately.

jonescc commented 8 years ago

OK to review/merge now.

julian1 commented 8 years ago

I'll review

julian1 commented 8 years ago

It's good that the behavior has been pushed out into config, but it still seems oddly specific to the data collection.

julian1 commented 8 years ago

No unit/ integration tests?

julian1 commented 8 years ago

finished!

jonescc commented 8 years ago

OK have made some changes. Adding integration tests would require a substantial amount of setup so perhaps that should be tackled as a backlog item.

jonescc commented 8 years ago

@julian1 for action

julian1 commented 8 years ago

@julian1 for action

rather bold.