search

aodn / geoserver-build

Configures a GeoServer war containing extensions and configuration required by AODN instances
Other
2 stars 4 forks source link

Allowing time to be absent for Javaduck #238

Closed pmbohm closed 7 years ago

pmbohm commented 7 years ago

See aodn/backlog#594

jonescc commented 7 years ago

Falls over with null pointer exception in FeatureSourceIndexReader trying to add a time filter.

jonescc commented 7 years ago

Review comments (mine) addressed. Allows time range not to be specified, which will include all indexed files for the requested collection in the aggregation regardless of included time.

Anyone want to review this? Its required to support the corresponding portal changes but does not require them.

jonescc commented 7 years ago

@bhasin85, perhaps wait until I've added a specific aggregation test for a file without a time axis. Really should have added a test for that.

bhasin85 commented 7 years ago

Thanks @jonescc for letting me know :+1:

jonescc commented 7 years ago

OK, @bhasin85 I've added a test aggregation of a dataset without a time axis (had to fix a couple of issues so good thing I added that test).

jonescc commented 7 years ago

Changes made @bhasin85