Time validation not flexible enough for oa_reconstruction aggregations

aodn / geoserver-build

Configures a GeoServer war containing extensions and configuration required by AODN instances

Other

2 stars 4 forks source link

Time validation not flexible enough for oa_reconstruction aggregations #250

Closed jonescc closed 7 years ago

jonescc commented 7 years ago

To reproduce

Submit an aggregation request for oa_reconstruction e.g request.txt

What happens

Get an error returned - "Invalid time format for subset: TIME,1870-07-17T19:38:33.16600Z,1870-07-17T19:38:33.16600Z;LATITUDE,-31.6855,-31.6855;LONGITUDE,114.8291,114.8291 Valid time format example: TIME,2009-01-01T00:00:00.000Z,2009-12-25T23:04:00.000Z"

What should happen

The aggregation is performed and the result returned.

jonescc commented 7 years ago

Introduced by https://github.com/aodn/geoserver-build/pull/245

We should get rid of the regex for validation its problematic. We should use joda times iso8601 parsing option instead - if it parses OK then it should be good enough for us. We should also add unit tests to ensure the different time possibilities we know about are tested at the very least.

pblain commented 7 years ago

This looks to have been fixed. Does anyone know if there's a reason this issue hasn't been closed?

jonescc commented 7 years ago

Wasn't linked in the associated PR.