Closed mhidas closed 10 years ago
Everything done as requested, not committed yet.
However I don't quite get how I could join in a nice way the tables together. for example
select COUNT(distinct taxon_name) from soop_auscpr.soop_auscpr_zoop_taxon_changelog
returns 121
and
select COUNT(distinct taxon_name) from soop_auscpr.soop_auscpr_zoop_trajectory_map
returns 616.
So the join of the two table is not a full one since a lot of taxon names appear to be missing in the *_CHANGELOG table from CMAR geoserver
You could do a left join on the soop_auscpr_zoop_taxon_changelog table so that you always get a result from soop_auscpr_zoop_taxon_changelog (either matching or null) for each taxon_name in soop_auscpr_zoop_trajectory_map.
Would that be acceptable?
@ggalibert that's actually what I ended up doing, see https://github.com/aodn/harvesters/tree/auscpr_update just waiting for someone to review the PR
For the next time, it would have actually been easier to review if you had made distinct commits for each of Marty's point above.
Do you really need timestamp(6) ~ 6 digits in the fractional part of second? I can see that you also use the default timestamp type.
In your iUpdateSpatialExtent component, the field GeoNetwork URL should be set to context.Metadata_URL
I'm not sure the updateMetadata component can be used with a tPostJob like you did.
Documentation mentioned above says "Add the subjob to run after harvesting in the main harvester job (making sure transmit whole context is ticked)", which tickbox you haven't ticked...
I can't find out how you did this left outer join.
@mhidas can we close this ?
Yes, I just merged your pull request #69
Thanks Loz for getting it all done!
The following changes are required:
Hope this all makes sense!