Handle case of WQM which didn't record one of it's primary variables

aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets

GNU General Public License v3.0

46 stars 31 forks source link

Handle case of WQM which didn't record one of it's primary variables #557

Closed ggalibert closed 5 years ago

ggalibert commented 5 years ago

See PR https://github.com/aodn/imos-toolbox/pull/555 .

@sspagnol can you please upload a zip file of an example of this misbehaved instrument file?

ocehugo commented 5 years ago

@sspagnol , can you provide the test file(s)?

@ggalibert, I'm just wondering if the requirements here are broader. Is this a problem that can occur in other readers besides WQM?

Requirements:

[x] A function to set attributes based on emptiness of root variables in WQM.
[x] Handle missing salinity
[x] function pass against files provided

sspagnol commented 5 years ago

Shortened example file attached. If we try and process this file with WQMHost to create dat file nothing is produced so had to import raw file in the toolbox (and hence code changes).

WQM0197_002_example.zip

Regards "Is this a problem that can occur in other readers besides WQM?", I hope note. The WQM when it works, works well; when it falls over then its a pain. They are slowy being phased out.

ocehugo commented 5 years ago

@sspagnol

can you also post the function signature (aka how did you call it, at which step)? I can run the readWQMraw.m on the file but would like to see if there can be any side effects on the execution tree.

modifications are now in PR #561