search

aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets
GNU General Public License v3.0
46 stars 31 forks source link

StarmonMiniParse.m file header formats changed #622

Closed BecCowley closed 4 years ago

BecCowley commented 4 years ago

I have the following header formats in our latest Starmon Mini files: (Ignore the apostrophies at the start, put them in to stop auto markdown, screenshot for clarity)

Screen Shot 2019-12-12 at 4 18 18 pm

'#B Created: 25.09.2019 03:52:48 '## Version SeaStar 7.61 '#5 Field separation: 0 '#2 Date & Time: 1 '#6 Decimal point: , '#7 Date def.: dd.mm.yyyy . '#8 Time def.: : '## Axis 0 Temperature(?C) clRed FALSE '## Series 0 Temp(?C) clRed 0 Temp(?C) 2 '## Recorder 3 Starmon mini 3998 '## Chart 3T3998DAT
'#D Data: 152105 15.04.2018 00:00:00 25.09.2019 03:20:00

The headerFormat in getHeader subfunction doesn't work with these headers:

headerFormat = '#%d\t%[^:]:\t%[^\r\n]'; headerContent = textscan(fileId, headerFormat, 'Delimiter', '');

Is it possible to get the format specifier updated soon? I can have a go if not! Thanks

BecCowley commented 4 years ago

I have edited the StarmonMiniParse.m code. Will submit it soon.

ocehugo commented 4 years ago

@BecCowley, thanks but we already know about it and got implemented - just missing to merge #621 and release.

BecCowley commented 4 years ago

@ocehugo, I have pulled down the new code. Can you tell me now how do I make the toolbox use the new parser? It still is using the old StarmonMiniParse.m

ocehugo commented 4 years ago

@BecCowley, I forgot to put the new parser on the GUI because the src file lies in a different place - PR will be here soon.

FYI: The new parser is called "Staroddi" and substitutes StarmonMini and StarmonDST. It supports older and new versions of the headers.

BecCowley commented 4 years ago

@ocehugo OK. I thought since the new code had already been added to the master it would work. I figured out the name change, but I wasn't sure if I had to nominate the parser in a .txt file somewhere. Let me know when it's ready to use. I can't do much till next year now.

ggalibert commented 4 years ago

Duplicate, see https://github.com/aodn/imos-toolbox/issues/549.

ocehugo commented 4 years ago

I shall explain myself - the parsers names will not be changed and the changes will be transparent (the change of names is internal only). This is so to avoid conflict with instruments.txt files, db matches, etc.

@BecCowley, you can use it if you merge https://github.com/aodn/imos-toolbox/pull/628 or wait it to be on master.