aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets
GNU General Public License v3.0
46 stars 31 forks source link

Main window plot axes resized when new data or flag option box selected #636

Open BecCowley opened 4 years ago

BecCowley commented 4 years ago

If the data is zoomed into a particular area on the main window plots and then a tick box is selected (eg, to add another variable plot), the axes return to the full plot range. I would like to see the current axes ranges retained if zoomed in.

In addition, the cursor status reverts (eg, if it was in zoom or pan, then any tick box is selected, the cursor returns to the QC status). Again, it would be nice for the cursor to carry its status after the plots are added or existing data is added etc.

This is a big issue for ADCP files where the plotting is very slow anyway due to the size of the files. To have to constantly re-zoom after adding plots to look at the area of interest is time consuming.

ocehugo commented 4 years ago

I know what you are talking about - the plot axis resets when selecting a new variable and the cursor returns to a regular state after some selections. It's a mixed problem of resetting (and redrawing) the axes/mouse state every time an option is select.

The problem here is that this changes the default behaviour of the GUI that has been like that a long time (I assume). I wonder, would some people prefer the current behaviour!? would the current behaviour help in any other workflow!?

The solution may be a button to detach/reattach a certain axes state from the others. I think the cursor case should be simpler since it's only one state.

Requirements:

BecCowley commented 4 years ago

I am not sure what others who use the toolbox think about this. @sspagnol - you might have an opinion? Perhaps if others like the current behaviour, the solution might be a 'hold zoom' check box which allows the user to over-ride the default behaviour and keep the current axes settings when adding/removing plots or whenever any other box is clicked (eg the 'hide bad data' and 'show data flag' boxes also cause everything to be reset). I think this is an important improvement as I am currently trying to QC single-ping ADCP data and the plotting is incredibly slow on these big files. The less re-drawing done the better.

I don't want the individual plots to have their axes unlinked from each other - if we zoom in on a section, all plots should zoom in together and keep that axes range on all plots.

The cursor behaviour is manageable, but I would like to see it retain whatever state last selected, no matter what updates are performed in the toolbox.

ocehugo commented 4 years ago

... and keep the current axes settings when adding/removing plots or whenever any other box is clicked (e.g. the 'hide bad data' and 'show data flag' boxes also cause everything to be reset).

Yeap, that is the case.

I don't want the individual plots to have their axes unlinked from each other - if we zoom in on a section, all plots should zoom in together and keep that axes range on all plots.

I didn't meant that, it's just a note (mostly for myself) that the functionality involves handling individual axis and attaching/reattaching them to the global axis limit that is currently reset at those events. I had to implement detaching (to keep zoom) and reattaching (to link with others) to a global reset call when work has ended, and people click on a left-menu box.

I think this is an important improvement as I am currently trying to QC single-ping ADCP data and the plotting is incredibly slow on these big files. The less re-drawing done the better.

I agree but if you look at our milestones issues, we got a lot of other stuff. We got a priority planning comming up so I will raise your point to increase the priority of this issue.

sspagnol commented 4 years ago

Perhaps if others like the current behaviour, the solution might be a 'hold zoom' check box which allows the user to over-ride the default behaviour and keep the current axes settings when adding/removing plots or whenever any other box is clicked (eg the 'hide bad data' and 'show data flag' boxes also cause everything to be reset).

Would like this also.