adcpBinMappingPP for new Nortek Signature

aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets

GNU General Public License v3.0

46 stars 31 forks source link

adcpBinMappingPP for new Nortek Signature #651

Open sspagnol opened 4 years ago

sspagnol commented 4 years ago

If I understand adcpBinMappingPP correctly if will bin map 4 beam RDI and 3 beam Nortek, as in convert DISTANCE_ALONG_BEAMS to HEIGHT_ABOVE_SENSOR, but I don't think it does this for new 4 beam Nortek Signatures.

ocehugo commented 4 years ago

@sspagnol , so this is a bug (we are remapping wrongly) or a feature (we can't map atm but will need to remap soonish)?

Also, could be a bit more specific about the instrument model & stacktrace of the toolbox (if any) + example file?

sspagnol commented 4 years ago

Attached is Nortek Signature 500 ad2cp file.

S100807A004_ROW01_avgd.zip

It was part of new NWSROW (Rowley Shoals) mooring (oriented down), which included an RDI (oriented up). When processed the RDI nc file had HEIGHT_ABOVE_SENSOR dimension but the Nortek didn't. So trying to understand did I miss something or is adcpBinMappingPP not working as expected.

ocehugo commented 4 years ago

Thanks.

I just had a quick look and, yes, we are totally skipping when we found ABSIC4 in Norteks. Logic is incomplete for signatures - there is no code that handles 4 beam cases.

Probably something simple, but I need some time to dig into adcpBinMappingPP and the specs/mapping trigonometry to do it right.

Requirements:

[ ] review Instrument specs and trigonometry/beam angle configuration.
[ ] Implement logic for Nortek Signatures in adcpBinMappingPP.

ocehugo commented 4 years ago

I knew this was somewhere - see #531