search

aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets
GNU General Public License v3.0
46 stars 31 forks source link

AutoQC configurations not updating #665

Open BecCowley opened 4 years ago

BecCowley commented 4 years ago

When adjusting thresholds in the AutoQC gui window, these values are not carried through to the test. Instead, the values previously saved in the .pqc file are used.

Eg, If I use the imosErrorVelocityQCSet test and choose to change the threshold by using the 'Configure ro...' button, the value I set in the configuration screen (or the value in the imosErrorVelocityQCSet.txt file) is read in line 83, but in line 88 it is reset to the value read from the *.pqc file.

This is quite a significant issue and I wonder if historical files have been flagged with incorrect threshold values. Are the values stated in the files what is actually applied?

To get around this issue, I am deleting the *.pqc files for the ADCP files I am processing before each run of the toolbox.

ocehugo commented 4 years ago

Confirmed. I agree the problem is the silently use/re-use of the value. I think the easier way is to pop-up a dialog box to confirm the value. I just wonder if we should pop-up the dialog box only when the default (txt) differs from the pqc file, or all the time.

Any thoughts? I think all the time is a good compromise because it avoids the case of "I changed the defaults in a previous session and forgot to use a different one for the new session".

ocehugo commented 4 years ago

Regarding the historical issue, this was the behaviour since 2017, ~2.6.1 (df6a8bf855d99c7ca3c96cb44dae9027076fde9a )

BecCowley commented 4 years ago

@ocehugo, a pop up box confirming changes would be good. Also it would be nice to see which values are applied somewhere in the main GUI window. Maybe in the QC statistics summary?