aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets
GNU General Public License v3.0
46 stars 31 forks source link

SpikeQC improvements #671

Open ocehugo opened 4 years ago

ocehugo commented 4 years ago

Recent requirements:

Further requirements:

sspagnol commented 4 years ago

In the window (that lists the variables) also have the instrument model-serial shown, as I've lost track of what file is being operated on.

ocehugo commented 4 years ago

@sspagnol , the instrument make and model are in the title of the window, unless they are undefined in the meta struct (see line 54 in spikeWindow.m).

sspagnol commented 4 years ago

My Matlab R2018b on Linux window looks like

image

Will check on Windows as well.

sspagnol commented 4 years ago

future improvements : In the preview window a reset to defaults button.

ocehugo commented 4 years ago

In the window (that lists the variables) also have the instrument model-serial shown, as I've lost track of what file is being operated on. @sspagnol , the instrument make and model are in the title of the window, unless they are undefined in the meta struct (see line 54 in spikeWindow.m). My Matlab R2018b on Linux window looks like ...

Correcting myself: The instrument name/model should be in the panel title, not the window title. And yes, it's not working atm, because I forgot to assign the instrument metadata to the structure that holds the reindexing information.

I got a fix here (see https://github.com/aodn/imos-toolbox/tree/improvements_spikeQC ), but will put together with the restore to defaults/reset thing before merging.

We need to release a hot fix, so will see if that can go together.