aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets
GNU General Public License v3.0
46 stars 31 forks source link

imosTiltVelocitytiltQC broken for ADCP #680

Closed ocehugo closed 4 years ago

ocehugo commented 4 years ago

Tim sent me an email with TiltQC marking way more data than it should for ADCP.

The problem was introduced in 2.6.7 with code for current meters. The logic that handles the ADCP multidimensional array is incorrect (reversed). The problem was that the tests for ADCP were also incorrect with wrong dimensions in ROLL/PITCH, which allow this problem to pass unnoticed.

TimAus-NSW commented 4 years ago

Can confirm fix works. Thanks.