aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets
GNU General Public License v3.0
46 stars 31 forks source link

Fix fieldname access imosTimeSeriesSpikeQC.m #681

Closed sspagnol closed 4 years ago

sspagnol commented 4 years ago

Testing for sample_data.FIELDNAME but accessing sample_data.meta.FIELDNAME

ocehugo commented 4 years ago

@sspagnol , is this blocking anything important apart from netcdf?

sspagnol commented 4 years ago

For me imosTimeSeriesSpikeQC.m was run when it was in the list of QC data routines, then matlab would throw error and so wouldn't get to the spike window (the one with list of variable and preview button). Dont' know about netcdf stuff. And only tested on a dataset the Vinnie was having trouble with.

ocehugo commented 4 years ago

Thanks. Just reproduced.

Lack of automated tests with real files on that one. damn, just minted a release...will need to do another and reverse the check here.

ocehugo commented 4 years ago

fixed in #682