aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets
GNU General Public License v3.0
46 stars 31 forks source link

EchoIntensitySetQC & imosSurfaceDetectionByDepthQC broken since 2.6.12 #742

Closed ocehugo closed 3 years ago

ocehugo commented 3 years ago

Release 2.6.12 broke some case handling in the new EchoIntensitySetQC and imosSurfaceDetectionByDepthQC.

The fix in 2.6.12 turned the logic handling of DIST_ALONG_BEAMS and HEIGHT_ABOVE_SENSOR invalid in these functions and they are now skipped/do not perform any action. two tests failed, but I somehow ignored them or I skipped running before the hot-fix.

ocehugo commented 3 years ago

closed by 67e52fb