search

aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets
GNU General Public License v3.0
46 stars 31 forks source link

Bug binmapping #755

Closed BecCowley closed 2 years ago

BecCowley commented 3 years ago

This fix is a sign adjustment to the bin mapping algorithm based on the direction the instrument is facing. Current code is only correct for down-facing ADCPs. Also adds the pitch gimbal correction.

BecCowley commented 2 years ago

@evacougnon, there are no further changes to this binmappingPP, I checked against my working version in the adcp_qc_updates branch and they are identical except for a few spaces/newlines.

evacougnon commented 2 years ago

Note to the reviewer: helpful info in this issue #753

BecCowley commented 2 years ago

@evacougnon Yes, will try rebasing.

BecCowley commented 2 years ago

@evacougnon, sorry I can't seem to be able to just create a pull request with the last two commits. I tried rebasing my master branch, creating a new branch and cherry-picking commits from this one into the new one. I still get a long list of merges and old commits when I try the new pull request. Can you work with this one, or do you have any other suggestions?

evacougnon commented 2 years ago

Closing this PR as the relevant commits are now in #777