search

aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets
GNU General Public License v3.0
45 stars 30 forks source link

ADCP Workshop 2021 - actionable items #768

Open hugo-sardi opened 2 years ago

hugo-sardi commented 2 years ago

Hi all,

As promised, here is a list of the actionable items we raised in the workshop. Please feel free to edit/reword and create new issues around it. I'm just dumping the list here so anyone can input more information or details.

Top priorities

1. Fix Bug in Error Velocity QC and update the wiki. (done) 2. Fix interactivity zoom when QC a new variable. ("easy") 3. Fix the window pop-up if user didn't click on qc stats after applying qc. "easy" 4. Finish RDI - BinMapping Downward data. ("medium") 5. Improve OceanContourParser to support more processing and different export cases (probably easy as long as we list our cases!?). Current issues/PR related to the OceanContour parser: https://github.com/aodn/imos-toolbox/issues/775 , https://github.com/aodn/imos-toolbox/pull/774 , https://github.com/aodn/imos-toolbox/pull/778 6. make Bec Plots for Thresholds available (histograms, pcolors, etc.) (done). 7. Reapply PP - Back and Forth Support. ("medium - possible side effects?)

  1. Integrate Thresholds plots (histograms/pcolors/etc) tightly into the GUI.
  2. Bec PP/QC Routines - Ringing/other modifications (maybe one issue for each?)
  3. SafetyNet/Training Wheels on PP/QC? Or reinforce documentation?
  4. Another avenue compared to OceanContour improvements (item 5).: Improve the signatureParser speed. (?longterm)
  5. Another avenue compared to OceanContour improvements (item 5): Allow bin-mapping of Nortek 4 beams (?longterm): https://github.com/aodn/imos-toolbox/pull/778
  6. Another avenue compared to OceanContour improvements (item 5): Allow beam2Enu from Nortek 4 beams (?longterm): https://github.com/aodn/imos-toolbox/pull/778
  7. ADCP Threshold window tool - allow interactivity to select thresholds.
  8. ADCP Single Ping processing - code is written - missing test/merge - how to join with upstream.
  9. ADCP Ensemble averaging - code is written - missing test/merge - how to join with upstream
  10. BUG: Impossible Depth PP not handling Bec case - instrument varying depth widely in the water column.
  11. Set new defaults: IMOS Salinity PT should be after the manualQC
  12. ADCP Temperature should be flag as bad automatically?
  13. Change the ADCP internal temperature metadata: name: INSTRUMENT_TEMP, and associated longname/variable descriptions (Majority vote)
  14. Change the ADCP depth metadata: name: INSTRUMENT_PRESSURE_REL, and associcated longname/variable descriptions. (Majority Vote).
  15. Store individual quality control results so we can track what test marked what.
  16. Updates Documentation: how to process RDI single/ensemble ping data - RDI tools to fix binary files with time drifts/pressure offsets/temperature record/sound velocity recalculations. [Simon/Bec].
  17. Tidal analysis - investigate the branch for tidal analysis and compare with what OceanCurrents is doing - also direct the results to detect timedrifts.
  18. Update documentation about PercentGood: Only applies to internally processed average data.
hugo-sardi commented 2 years ago

For the record, I already got some changes for item 5 in the list - poke me if you are in need of OceanContour support.

Poking @BecCowley and @sspagnol too because they got actionable items related to the list.

petejan commented 2 years ago

A couple of changes to the ADCP netCDF format would be good,

  1. Put the depth of each current observation into the netCDF file, so depth will have the same dimensions as the current variables (TIME, HEIGHT_ABOVE_SENSOR). At the moment the user has to calculate the depth of each observation by combining the height_above_sensor and (instrument) depth.
  2. The ADCP files could also be flattened, to a observation of time, depth, current, all with the single dimensions of OBS. The file is simply a bunch of current observations at a time and depth.
ggalibert commented 2 years ago

@hugo-sardi thank you for the summary of actionnable items, would you please be able to point to existing issues/PRs in the repo or create a relevant one if not existing? I only managed to map one I was sure of.